[MD History] Close delete items dialog when a new query is initiated.

chrome/test/data/webui/md_history/history_list_test.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('md_history.history_list_test', function() {
   function registerTests() {
     suite('history-list', function() {
       var app;
       var element;
       var toolbar;
@@ skipping 230 matching lines @@
 
           MockInteractions.tap(app.$.toolbar.$$('#delete-button'));
 
           // Confirmation dialog should appear.
           assertTrue(listContainer.$.dialog.opened);
 
           MockInteractions.tap(listContainer.$$('.action-button'));
         });
       });
 
+      test('delete dialog closed on url change', function() {
+        app.queryState_.queryingDisabled = false;
+        var listContainer = app.$.history;
+        app.historyResult(createHistoryInfo(), TEST_HISTORY_RESULTS);
+        app.historyResult(createHistoryInfo(), ADDITIONAL_RESULTS);
+        return flush().then(function() {
+          items = Polymer.dom(element.root).querySelectorAll('history-item');
+
+          MockInteractions.tap(items[2].$.checkbox);
+          MockInteractions.tap(app.$.toolbar.$$('#delete-button'));
+
+          // Confirmation dialog should appear.
+          assertTrue(listContainer.$.dialog.opened);
+
+          app.set('queryState_.searchTerm', 'something else');
+          assertFalse(listContainer.$.dialog.opened);
+        });
+      });
+
       teardown(function() {
         element.historyData_ = [];
         registerMessageCallback('removeVisits', this, undefined);
-        registerMessageCallback('queryHistory', this, undefined);
+        registerMessageCallback('queryHistory', this, function() {});

[tsergeant, 2016/07/28 07:20:45]

Why is this necessary? Should we be doing this everywhere?

[calamity, 2016/08/01 02:46:11]

The added test fails with cannot read property 'apply' of undefined, because
queryHistory does a chrome.send which just tried to call undefined.

This is only necessary because I want querying to not be disabled in that last
test, but I also didn't want to listen to it.

         app.queryState_.queryingDisabled = true;
         app.set('queryState_.searchTerm', '');
         return flush();
       });
     });
   }
   return {
     registerTests: registerTests
   };
 });