Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2186073002: Rename GrContext's newDrawContext & drawContext to makeDrawContext (Closed)

Created:
4 years, 4 months ago by robertphillips
Modified:
4 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename GrContext's newDrawContext & drawContext to makeDrawContext These both return sk_sp. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2186073002 Committed: https://skia.googlesource.com/skia/+/6738c702423226619ee0172c12a3a007c5f68e57

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -174 lines) Patch
M include/gpu/GrContext.h View 1 chunk +10 lines, -10 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/core/SkSpecialSurface.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrBlurUtils.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrContext.cpp View 6 chunks +15 lines, -15 lines 0 comments Download
M src/gpu/GrRenderTarget.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTextureParamsAdjuster.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrTextureToYUVPlanes.cpp View 1 chunk +15 lines, -15 lines 0 comments Download
M src/gpu/GrYUVProvider.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 3 chunks +13 lines, -13 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/ClearTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/DFPathRendererTest.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
M tests/GLProgramsTest.cpp View 2 chunks +12 lines, -12 lines 0 comments Download
M tests/PrimitiveProcessorTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/RectangleTextureTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/SRGBMipMapTest.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/TessellatingPathRendererTests.cpp View 1 chunk +24 lines, -24 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
robertphillips
4 years, 4 months ago (2016-07-27 17:20:04 UTC) #4
bsalomon
lgtm
4 years, 4 months ago (2016-07-27 17:21:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2186073002/1
4 years, 4 months ago (2016-07-27 19:12:35 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 19:13:54 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/6738c702423226619ee0172c12a3a007c5f68e57

Powered by Google App Engine
This is Rietveld 408576698