Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 2186053002: Add context menu to snippets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
index 917cfb384ca42c5c2234eb1d63e8eb81128bbbac..5d60e1243c4558f26a5db6cf0df94365f0596f14 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
@@ -137,6 +137,12 @@ public class NewTabPageView extends FrameLayout
/** @return Whether the omnibox 'Search or type URL' text should be shown. */
boolean isFakeOmniboxTextEnabledTablet();
+ /** @return Whether context menus should allow the option to open a link in a new window. */
+ boolean isOpenInNewWindowEnabled();
+
+ /** @return Whether context menus should allow the option to open a link in incognito. */
+ boolean isOpenInIncognitoEnabled();
+
/** Opens the bookmarks page in the current tab. */
void navigateToBookmarks();
@@ -144,14 +150,20 @@ public class NewTabPageView extends FrameLayout
void navigateToRecentTabs();
/**
- * Opens an url in the current tab and records related metrics.
+ * Opens a URL in the current tab and records related metrics.
* @param url the URL to open
*/
void openSnippet(String url);
- /** Opens a url in the current tab. */
+ /** Opens a URL in the current tab. */
void openUrl(String url);
+ /** Opens a URL in a new window. */
+ void openUrlInNewWindow(String url);
+
+ /** Opens a URL in a new tab. */
+ void openUrlInNewTab(String url, boolean incognito);
+
/**
* Animates the search box up into the omnibox and bring up the keyboard.
* @param beginVoiceSearch Whether to begin a voice search.

Powered by Google App Engine
This is Rietveld 408576698