VideoCaptureDeviceAndroid: add ThreadChecker, lock access to |client_|, mini cleanup

VideoCaptureDeviceAndroid: add ThreadChecker, lock access to |client_|, mini cleanup

This CL:

- Adds a thread checker to VideoCaptureDeviceAndroid,
- reduces the scope of an AutoLock protecting |client_|
- adds AutoLock in (other) accesses to |client_| and
 tests for it before using it.
- cleans up (removes) superfluous DVLOG()s
- reorders 1 member variable

Committed: https://crrev.com/2a9a0be57eb38d4937e1cc2ef2737ae8a9a74289
Cr-Commit-Position: refs/heads/master@{#408238}

[mcasas, 2016-07-27 16:03:47]

Description was changed from

==========
VideoCaptureDeviceAndroid: add a ThreadChecker and cleanup
==========

to

==========
VideoCaptureDeviceAndroid: add a ThreadChecker and cleanup

- Added a thread checker to VideoCaptureDeviceAndroid, 
- cleaned up (removed) superfluous DVLOG()s
- reduced scope of an AutoLock
- reordered 1 member variable
==========

[mcasas, 2016-07-27 16:05:44]

mcasas@chromium.org changed reviewers:
+ chfremer@chromium.org

[mcasas, 2016-07-27 16:05:44]

chfremer@ cleanup CL, PTAL

[chfremer, 2016-07-27 17:07:59]

https://codereview.chromium.org/2186043002/diff/1/media/capture/video/android...
File media/capture/video/android/video_capture_device_android.cc (right):

https://codereview.chromium.org/2186043002/diff/1/media/capture/video/android...
media/capture/video/android/video_capture_device_android.cc:234: }
Not sure we really can reduce the scope of the lock like this.
Couldn't it happen that between this position and the usage of |client_| in line
257 a call to StopAndDeallocate() arrives that resets |client_| to nullptr? 

And if this were the case, I would also be concerned about the access to
|client_| at lines 311 and 378 that are not protected by a lock.

[mcasas, 2016-07-27 18:40:29]

Description was changed from

==========
VideoCaptureDeviceAndroid: add a ThreadChecker and cleanup

- Added a thread checker to VideoCaptureDeviceAndroid, 
- cleaned up (removed) superfluous DVLOG()s
- reduced scope of an AutoLock
- reordered 1 member variable
==========

to

==========
VideoCaptureDeviceAndroid: add ThreadChecker, lock access to |client_|, mini
cleanup

This CL:

- Adds a thread checker to VideoCaptureDeviceAndroid, 
- reduces the scope of an AutoLock protecting |client_|
- adds AutoLock in (other) accesses to |client_| and
 tests for it before using it.
- cleans up (removes) superfluous DVLOG()s
- reorders 1 member variable
==========

[mcasas, 2016-07-27 18:40:54]

PTAL

https://codereview.chromium.org/2186043002/diff/1/media/capture/video/android...
File media/capture/video/android/video_capture_device_android.cc (right):

https://codereview.chromium.org/2186043002/diff/1/media/capture/video/android...
media/capture/video/android/video_capture_device_android.cc:234: }
On 2016/07/27 17:07:59, chfremer wrote:
> Not sure we really can reduce the scope of the lock like this.
> Couldn't it happen that between this position and the usage of |client_| in
line
> 257 a call to StopAndDeallocate() arrives that resets |client_| to nullptr? 
> 
> And if this were the case, I would also be concerned about the access to
> |client_| at lines 311 and 378 that are not protected by a lock.

You're right, done.

[chfremer, 2016-07-27 19:24:25]

lgtm

[mcasas, 2016-07-27 20:09:50]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-07-27 20:10:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 21:17:04]

Description was changed from

==========
VideoCaptureDeviceAndroid: add ThreadChecker, lock access to |client_|, mini
cleanup

This CL:

- Adds a thread checker to VideoCaptureDeviceAndroid, 
- reduces the scope of an AutoLock protecting |client_|
- adds AutoLock in (other) accesses to |client_| and
 tests for it before using it.
- cleans up (removes) superfluous DVLOG()s
- reorders 1 member variable
==========

to

==========
VideoCaptureDeviceAndroid: add ThreadChecker, lock access to |client_|, mini
cleanup

This CL:

- Adds a thread checker to VideoCaptureDeviceAndroid, 
- reduces the scope of an AutoLock protecting |client_|
- adds AutoLock in (other) accesses to |client_| and
 tests for it before using it.
- cleans up (removes) superfluous DVLOG()s
- reorders 1 member variable
==========

[commit-bot: I haz the power, 2016-07-27 21:17:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-27 21:19:04]

Description was changed from

==========
VideoCaptureDeviceAndroid: add ThreadChecker, lock access to |client_|, mini
cleanup

This CL:

- Adds a thread checker to VideoCaptureDeviceAndroid, 
- reduces the scope of an AutoLock protecting |client_|
- adds AutoLock in (other) accesses to |client_| and
 tests for it before using it.
- cleans up (removes) superfluous DVLOG()s
- reorders 1 member variable
==========

to

==========
VideoCaptureDeviceAndroid: add ThreadChecker, lock access to |client_|, mini
cleanup

This CL:

- Adds a thread checker to VideoCaptureDeviceAndroid,
- reduces the scope of an AutoLock protecting |client_|
- adds AutoLock in (other) accesses to |client_| and
 tests for it before using it.
- cleans up (removes) superfluous DVLOG()s
- reorders 1 member variable

Committed: https://crrev.com/2a9a0be57eb38d4937e1cc2ef2737ae8a9a74289
Cr-Commit-Position: refs/heads/master@{#408238}
==========

[commit-bot: I haz the power, 2016-07-27 21:19:05]

Patchset 2 (id:??) landed as
https://crrev.com/2a9a0be57eb38d4937e1cc2ef2737ae8a9a74289
Cr-Commit-Position: refs/heads/master@{#408238}