Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2186013002: Add a jss gdb macro that skips over the jitted stack in gdb (Closed)

Created:
4 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add a jss gdb macro that skips over the jitted stack in gdb Use it like this: Program received signal SIGTRAP, Trace/breakpoint trap. [Switching to Thread 0x7f50d02c4700 (LWP 8152)] base::debug::(anonymous namespace)::DebugBreak () at ../../base/debug/debugger_posix.cc:230 230 } (gdb) bt at ../../base/debug/debugger_posix.cc:230 ... args_object=0x7f50d02bfe00, isolate=0x2f001c9e2020) at ../../v8/src/builtins/builtins-api.cc:123 ... (gdb) jss (gdb) bt isolate=0x2f001c9e2020, is_construct=false, target=..., receiver=..., argc=1, args=0x7f50d02c0518, new_target=...) at ../../v8/src/execution.cc:111 isolate=0x2f001c9e2020, callable=..., receiver=..., argc=1, argv=0x7f50d02c0518) at ../../v8/src/execution.cc:168 ... R=yangguo@chromium.org BUG= Committed: https://crrev.com/a8118084328234d1f9f8fffb998e134cdda6356b Cr-Commit-Position: refs/heads/master@{#38121}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M tools/gdbinit View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
jochen (gone - plz use gerrit)
4 years, 4 months ago (2016-07-27 14:30:32 UTC) #1
jochen (gone - plz use gerrit)
jss as in javascript skip stack
4 years, 4 months ago (2016-07-27 14:32:15 UTC) #4
Yang
On 2016/07/27 14:32:15, jochen wrote: > jss as in javascript skip stack Nice. LGTM.
4 years, 4 months ago (2016-07-28 09:01:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2186013002/1
4 years, 4 months ago (2016-07-28 09:03:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 09:04:44 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 09:06:54 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8118084328234d1f9f8fffb998e134cdda6356b
Cr-Commit-Position: refs/heads/master@{#38121}

Powered by Google App Engine
This is Rietveld 408576698