Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: cc/layers/solid_color_scrollbar_layer.h

Issue 2185973005: cc: Move solid color scrollbar layer data in a seperate struct. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: .. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/picture_layer_unittest.cc ('k') | cc/layers/solid_color_scrollbar_layer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/solid_color_scrollbar_layer.h
diff --git a/cc/layers/solid_color_scrollbar_layer.h b/cc/layers/solid_color_scrollbar_layer.h
index 9bd83f5148e9e27ff7ae23c5b0243a489b9d0aa4..8741efa770b7ce0b11dff9cdcd179e3bba4f9721 100644
--- a/cc/layers/solid_color_scrollbar_layer.h
+++ b/cc/layers/solid_color_scrollbar_layer.h
@@ -57,11 +57,23 @@ class CC_EXPORT SolidColorScrollbarLayer : public ScrollbarLayerInterface,
private:
friend class LayerSerializationTest;
- int scroll_layer_id_;
- ScrollbarOrientation orientation_;
- int thumb_thickness_;
- int track_start_;
- bool is_left_side_vertical_scrollbar_;
+ // Encapsulate all data, callbacks, interfaces received from the embedder.
+ struct SolidColorScrollbarLayerInputs {
+ SolidColorScrollbarLayerInputs(ScrollbarOrientation orientation,
+ int thumb_thickness,
+ int track_start,
+ bool is_left_side_vertical_scrollbar,
+ int scroll_layer_id);
+ ~SolidColorScrollbarLayerInputs();
+
+ int scroll_layer_id;
+ ScrollbarOrientation orientation;
+ int thumb_thickness;
+ int track_start;
+ bool is_left_side_vertical_scrollbar;
+ };
+
+ SolidColorScrollbarLayerInputs solid_color_scrollbar_layer_inputs_;
DISALLOW_COPY_AND_ASSIGN(SolidColorScrollbarLayer);
};
« no previous file with comments | « cc/layers/picture_layer_unittest.cc ('k') | cc/layers/solid_color_scrollbar_layer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698