Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2185973005: cc: Move solid color scrollbar layer data in a seperate struct. (Closed)

Created:
4 years, 4 months ago by Khushal
Modified:
4 years, 4 months ago
Reviewers:
ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Move solid color scrollbar layer data in a seperate struct. Just a clean up as a part of Layers cleanup. BUG=625284 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/11c20a91030988c6938c831ebe2c128d275a57c6 Cr-Commit-Position: refs/heads/master@{#408813}

Patch Set 1 #

Patch Set 2 : .. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -60 lines) Patch
M cc/layers/layer_unittest.cc View 1 1 chunk +18 lines, -10 lines 0 comments Download
M cc/layers/picture_layer.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M cc/layers/picture_layer.cc View 1 8 chunks +14 lines, -13 lines 0 comments Download
M cc/layers/picture_layer_unittest.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M cc/layers/solid_color_scrollbar_layer.h View 1 1 chunk +17 lines, -5 lines 0 comments Download
M cc/layers/solid_color_scrollbar_layer.cc View 1 6 chunks +48 lines, -27 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
Khushal
Trivial change since we are moving data in all these classes into structs.
4 years, 4 months ago (2016-07-28 22:22:19 UTC) #3
ajuma
lgtm
4 years, 4 months ago (2016-07-28 23:34:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185973005/1
4 years, 4 months ago (2016-07-29 00:27:19 UTC) #6
commit-bot: I haz the power
Your CL was about to rely on recently removed CQ feature(s): * master.tryserver.blink builder linux_blink_rel ...
4 years, 4 months ago (2016-07-29 00:27:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185973005/1
4 years, 4 months ago (2016-07-29 00:38:00 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/252206)
4 years, 4 months ago (2016-07-29 00:49:27 UTC) #13
Khushal
On 2016/07/29 00:49:27, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 4 months ago (2016-07-29 01:26:07 UTC) #14
ajuma
On 2016/07/29 01:26:07, Khushal wrote: > On 2016/07/29 00:49:27, commit-bot: I haz the power wrote: ...
4 years, 4 months ago (2016-07-29 22:52:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185973005/20001
4 years, 4 months ago (2016-07-29 23:08:09 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-30 00:07:05 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-07-30 00:09:06 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/11c20a91030988c6938c831ebe2c128d275a57c6
Cr-Commit-Position: refs/heads/master@{#408813}

Powered by Google App Engine
This is Rietveld 408576698