Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2185973004: [interpreter] Extend test for OSR from within generators. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, neis
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Extend test for OSR from within generators. R=rmcilroy@chromium.org TEST=mjsunit/ignition/osr-from-generator BUG=v8:4764 Committed: https://crrev.com/70489a1be53860276ff72e9c5ab44e605695b5cf Cr-Commit-Position: refs/heads/master@{#38144}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M test/mjsunit/ignition/osr-from-generator.js View 3 chunks +18 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 4 months ago (2016-07-28 11:24:01 UTC) #3
rmcilroy
LGTM, thanks.
4 years, 4 months ago (2016-07-28 16:20:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185973004/1
4 years, 4 months ago (2016-07-28 16:49:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 16:51:16 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 16:52:37 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70489a1be53860276ff72e9c5ab44e605695b5cf
Cr-Commit-Position: refs/heads/master@{#38144}

Powered by Google App Engine
This is Rietveld 408576698