Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: components/offline_pages/offline_page_model_impl.cc

Issue 2185973003: [Offline Pages] Delete associated page along with bookmark. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding offline_pages::ExternalListener. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model_impl.cc
diff --git a/components/offline_pages/offline_page_model_impl.cc b/components/offline_pages/offline_page_model_impl.cc
index a4d63b2595aa929393db9452dd9373ae7f60891c..fc66afffc3f0e795a91ac5b8dbd1b0ba260cc97e 100644
--- a/components/offline_pages/offline_page_model_impl.cc
+++ b/components/offline_pages/offline_page_model_impl.cc
@@ -17,6 +17,7 @@
#include "base/strings/string_number_conversions.h"
#include "base/threading/thread_task_runner_handle.h"
#include "base/time/time.h"
+#include "components/bookmarks/browser/bookmark_node.h"
#include "components/offline_pages/archive_manager.h"
#include "components/offline_pages/client_namespace_constants.h"
#include "components/offline_pages/client_policy_controller.h"
@@ -1068,6 +1069,23 @@ void OfflinePageModelImpl::PostClearStorageIfNeededTask() {
weak_ptr_factory_.GetWeakPtr())));
}
+void OfflinePageModelImpl::ExpireRemovedBookmarkPage(
+ const bookmarks::BookmarkNode* node) {
+ ClientId client_id(kBookmarkNamespace, std::to_string(node->id()));
+ GetOfflineIdsForClientId(
+ client_id, base::Bind(&OfflinePageModelImpl::DoExpireRemovedBookmarkPages,
+ weak_ptr_factory_.GetWeakPtr()));
+}
+
+void OfflinePageModelImpl::DoExpireRemovedBookmarkPages(
+ const std::vector<int64_t>& offline_ids) {
+ ExpirePages(offline_ids, base::Time::Now(),
+ base::Bind(&OfflinePageModelImpl::OnRemovedBookmarkPagesExpired,
+ weak_ptr_factory_.GetWeakPtr()));
+}
+
+void OfflinePageModelImpl::OnRemovedBookmarkPagesExpired(bool result) {}
+
void OfflinePageModelImpl::RunWhenLoaded(const base::Closure& task) {
if (!is_loaded_) {
delayed_tasks_.push_back(task);

Powered by Google App Engine
This is Rietveld 408576698