chrome/browser/bookmarks/chrome_bookmark_client.h - Issue 2185973003: [Offline Pages] Delete associated page along with bookmark.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bookmarks/chrome_bookmark_client.h

Issue 2185973003: [Offline Pages] Delete associated page along with bookmark. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding offline_pages::ExternalListener. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/bookmarks/bookmark_model_factory.cc ('K') | « chrome/browser/bookmarks/bookmark_model_factory.cc ('k') | chrome/browser/bookmarks/chrome_bookmark_client.cc » ('j') | components/bookmarks/browser/bookmark_model.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/bookmarks/chrome_bookmark_client.h

diff --git a/chrome/browser/bookmarks/chrome_bookmark_client.h b/chrome/browser/bookmarks/chrome_bookmark_client.h

index 621f408fc0b2b1298b6ecbd891324130e54bff23..77da9e168340e2e74d0d6e898e8b04ff3964a7a0 100644

--- a/chrome/browser/bookmarks/chrome_bookmark_client.h

+++ b/chrome/browser/bookmarks/chrome_bookmark_client.h

@@ -5,6 +5,7 @@

#ifndef CHROME_BROWSER_BOOKMARKS_CHROME_BOOKMARK_CLIENT_H_

#define CHROME_BROWSER_BOOKMARKS_CHROME_BOOKMARK_CLIENT_H_

+#include <memory>

#include <set>

#include <vector>

@@ -26,6 +27,10 @@ class BookmarkPermanentNode;

class ManagedBookmarkService;

}

+namespace offline_pages {

Dmitry Titov 2016/08/12 05:43:43 are there changes in this class?

romax 2016/08/16 19:05:44 i think this thing was left behind. deleted.

+class ExternalListener;

class ChromeBookmarkClient : public bookmarks::BookmarkClient {

public:

ChromeBookmarkClient(