components/offline_pages/offline_page_model_impl.h - Issue 2185973003: [Offline Pages] Delete associated page along with bookmark.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_model_impl.h

Issue 2185973003: [Offline Pages] Delete associated page along with bookmark. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename Owned* to OfflinePageBookmarkObserver and Impl classes. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/bookmarks/browser/bookmark_model.cc ('K') | « components/offline_pages/BUILD.gn ('k') | components/sync_bookmarks/bookmark_data_type_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/offline_page_model_impl.h

diff --git a/components/offline_pages/offline_page_model_impl.h b/components/offline_pages/offline_page_model_impl.h

index 06c9e43434904689f4215b6bd68c2f29464de304..c06eba233f4e038a4177c631d4d3a5ac4a4cc844 100644

--- a/components/offline_pages/offline_page_model_impl.h

+++ b/components/offline_pages/offline_page_model_impl.h

@@ -274,7 +274,7 @@ class OfflinePageModelImpl : public OfflinePageModel, public KeyedService {

bool is_loaded_;

- // In memory copy of the offline page metadata, keyed by bookmark IDs.

+ // In memory copy of the offline page metadata, keyed by offline IDs.

std::map<int64_t, OfflinePageItem> offline_pages_;

// Pending archivers owned by this model.