Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Unified Diff: components/browser_sync/browser/profile_sync_service_bookmark_unittest.cc

Issue 2185973003: [Offline Pages] Delete associated page along with bookmark. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rename Owned* to OfflinePageBookmarkObserver and Impl classes. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_sync/browser/profile_sync_service_bookmark_unittest.cc
diff --git a/components/browser_sync/browser/profile_sync_service_bookmark_unittest.cc b/components/browser_sync/browser/profile_sync_service_bookmark_unittest.cc
index 59fb1c7e8269504f0437adc4054c343663279e3d..42e6fe18b35f577623d93f66c2d2140ef26ac7e8 100644
--- a/components/browser_sync/browser/profile_sync_service_bookmark_unittest.cc
+++ b/components/browser_sync/browser/profile_sync_service_bookmark_unittest.cc
@@ -32,8 +32,10 @@
#include "components/bookmarks/browser/base_bookmark_model_observer.h"
#include "components/bookmarks/browser/bookmark_model.h"
#include "components/bookmarks/browser/bookmark_utils.h"
+#include "components/bookmarks/browser/offline_page_bookmark_observer.h"
#include "components/bookmarks/managed/managed_bookmark_service.h"
#include "components/bookmarks/test/bookmark_test_helpers.h"
+#include "components/bookmarks/test/mock_bookmark_model_observer.h"
#include "components/bookmarks/test/test_bookmark_client.h"
#include "components/browser_sync/browser/profile_sync_test_util.h"
#include "components/sync/api/sync_error.h"
@@ -438,7 +440,8 @@ class ProfileSyncServiceBookmarkTest : public testing::Test {
std::unique_ptr<BookmarkModel> CreateBookmarkModel(bool delete_bookmarks) {
const base::FilePath& data_path = data_dir_.path();
auto model = base::MakeUnique<BookmarkModel>(
- base::WrapUnique(new bookmarks::TestBookmarkClient()));
+ base::WrapUnique(new bookmarks::TestBookmarkClient()),
+ base::WrapUnique(new bookmarks::OfflinePageBookmarkObserver()));
managed_bookmark_service_->BookmarkModelCreated(model.get());
int64_t next_id = 0;
static_cast<bookmarks::TestBookmarkClient*>(model->client())

Powered by Google App Engine
This is Rietveld 408576698