components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc - Issue 2185973003: [Offline Pages] Delete associated page along with bookmark.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc

Issue 2185973003: [Offline Pages] Delete associated page along with bookmark. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removing debug lines. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/base/testing_profile.cc ('K') | « components/bookmarks/browser/owned_bookmark_model_observer.h ('k') | components/bookmarks/test/test_bookmark_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc

diff --git a/components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc b/components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc

index a3d3bb256aec74f46dc06e144e87f9e6eb621afa..e629f9d18d23ff3e3daa483cdee78c61a839cdbe 100644

--- a/components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc

+++ b/components/bookmarks/managed/managed_bookmarks_tracker_unittest.cc

@@ -17,6 +17,7 @@

#include "components/bookmarks/browser/bookmark_model_observer.h"

#include "components/bookmarks/browser/bookmark_node.h"

#include "components/bookmarks/browser/bookmark_utils.h"

+#include "components/bookmarks/browser/owned_bookmark_model_observer.h"

#include "components/bookmarks/common/bookmark_pref_names.h"

#include "components/bookmarks/test/bookmark_test_helpers.h"

#include "components/bookmarks/test/mock_bookmark_model_observer.h"

@@ -66,7 +67,9 @@ class ManagedBookmarksTrackerTest : public testing::Test {

std::unique_ptr<TestBookmarkClient> client(new TestBookmarkClient);

client->SetExtraNodesToLoad(std::move(extra_nodes));

- model_.reset(new BookmarkModel(std::move(client)));

+ std::unique_ptr<OwnedBookmarkModelObserver> observer(

+ new OwnedBookmarkModelObserver);

+ model_.reset(new BookmarkModel(std::move(client), std::move(observer)));

model_->AddObserver(&observer_);

EXPECT_CALL(observer_, BookmarkModelLoaded(model_.get(), _));