[Offline Pages] Delete associated page along with bookmark.

chrome/browser/android/offline_pages/offline_page_bookmark_observer.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_BOOKMARK_OBSERVER_H_
+#define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_BOOKMARK_OBSERVER_H_
+
+#include "chrome/browser/android/offline_pages/offline_page_model_factory.h"
+
+#include "components/bookmarks/browser/owned_bookmark_model_observer.h"
+#include "components/offline_pages/offline_page_types.h"
+
+class GURL;
+class Profile;
+
+namespace bookmarks {
+class BookmarkModel;
+class BookmarkNode;
+}
+
+namespace offline_pages {
+
+class OfflinePageBookmarkObserver
+    : public bookmarks::OwnedBookmarkModelObserver {
+ public:
+  explicit OfflinePageBookmarkObserver(Profile* profile);
+
+  ~OfflinePageBookmarkObserver() override {}
+
+  void BookmarkModelChanged() override {}

[Dmitry Titov, 2016/08/26 23:08:59]

no need to override this.
Also, we typically group the overrides of each interface together with a comment
saying which overrides those are.

[romax, 2016/08/29 22:58:02]

Done.

+
+  void BookmarkNodeRemoved(bookmarks::BookmarkModel* model,
+                           const bookmarks::BookmarkNode* parent,
+                           int old_index,
+                           const bookmarks::BookmarkNode* node,
+                           const std::set<GURL>& removed_urls) override;
+
+  void DoExpireRemovedBookmarkPages(const MultipleOfflineIdResult& offline_ids);
+
+  void OnExpireRemovedBookmarkPagesDone(bool result);
+
+ private:
+  Profile* profile_;
+
+  OfflinePageModel* offline_page_model_;

[Dmitry Titov, 2016/08/26 23:08:59]

What is a lifetime of that? What if the OPM is destroyed before BookmarkModel
that controls lifetime of this class?

[romax, 2016/08/29 22:58:02]

The OPM itself should be independent, and if we destroyed the OPM, then next
time if we would like to call the callback it would create an OPM again since
the pointer is nullptr? It's more like a weak_ptr.

+};
+}  // namespace offline_pages
+
+#endif  // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_BOOKMARK_OBSERVER_H_