Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2185943003: Support C++ bindings for the DevTools Log Domain in headless_lib (Closed)

Created:
4 years, 4 months ago by alex clarke (OOO till 29th)
Modified:
4 years, 4 months ago
Reviewers:
Sami
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support C++ bindings for the DevTools Log Domain in headless_lib BUG=546953 Committed: https://crrev.com/87b0fab359eb7ae263285961a23f8782011488d7 Cr-Commit-Position: refs/heads/master@{#408091}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M headless/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M headless/lib/browser/headless_devtools_client_impl.h View 3 chunks +3 lines, -0 lines 0 comments Download
M headless/lib/browser/headless_devtools_client_impl.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M headless/public/headless_devtools_client.h View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
alex clarke (OOO till 29th)
4 years, 4 months ago (2016-07-27 10:04:54 UTC) #3
Sami
lgtm.
4 years, 4 months ago (2016-07-27 10:06:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185943003/1
4 years, 4 months ago (2016-07-27 10:12:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 10:52:29 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 10:54:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/87b0fab359eb7ae263285961a23f8782011488d7
Cr-Commit-Position: refs/heads/master@{#408091}

Powered by Google App Engine
This is Rietveld 408576698