Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: pkg/analyzer/lib/src/task/options.dart

Issue 2185873002: Default trailing comma support to `true` (#26647). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/task/dart.dart ('k') | pkg/analyzer/test/generated/parser_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/task/options.dart
diff --git a/pkg/analyzer/lib/src/task/options.dart b/pkg/analyzer/lib/src/task/options.dart
index a101147344ffc772f1c17454c00ca3c055ff9c1d..6cf558582f4f160f0c9a672b364fc859018f53d6 100644
--- a/pkg/analyzer/lib/src/task/options.dart
+++ b/pkg/analyzer/lib/src/task/options.dart
@@ -49,7 +49,6 @@ class AnalyzerOptions {
static const String enableGenericMethods = 'enableGenericMethods';
static const String enableStrictCallChecks = 'enableStrictCallChecks';
static const String enableSuperMixins = 'enableSuperMixins';
- static const String enableTrailingCommas = 'enableTrailingCommas';
static const String errors = 'errors';
static const String exclude = 'exclude';
@@ -88,8 +87,7 @@ class AnalyzerOptions {
enableAsync,
enableGenericMethods,
enableStrictCallChecks,
- enableSuperMixins,
- enableTrailingCommas
+ enableSuperMixins
];
}
@@ -504,14 +502,6 @@ class _OptionsProcessor {
context.analysisOptions = options;
}
}
- if (feature == AnalyzerOptions.enableTrailingCommas) {
- if (isTrue(value)) {
- AnalysisOptionsImpl options =
- new AnalysisOptionsImpl.from(context.analysisOptions);
- options.enableTrailingCommas = true;
- context.analysisOptions = options;
- }
- }
if (feature == AnalyzerOptions.enableGenericMethods) {
if (isTrue(value)) {
AnalysisOptionsImpl options =
« no previous file with comments | « pkg/analyzer/lib/src/task/dart.dart ('k') | pkg/analyzer/test/generated/parser_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698