Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2185833004: DEPS bump to pull in linter `0.1.22`. (Closed)

Created:
4 years, 4 months ago by pquitslund
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

DEPS bump to pull in linter `0.1.22`. Linter `0.1.22`. * Grinder support (`rule:rule_name` and `docs:location`) for rule stub and doc generation (respectively). * Fix to allow leading underscores in `non_constant_identifier_names`. * New `valid_regexps` lint (#277). * New `whitespace_around_ops` lint (#249). * Fix to `overridden_fields` to flag overridden static fields (#274). * New `list_remove_unrelated_type` to detect passing a non-`T` value to `List.remove()`` (#271). * New `empty_catches` lint to catch empty catch blocks (#43). * Fixed `close_sinks` false positive (#268). * Added `linter` support for `--strong` to allow for running linter in strong mode. BUG= R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/da84692f578d7bc9f5173077155707f910d4d1ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
4 years, 4 months ago (2016-07-27 14:53:29 UTC) #2
Brian Wilkerson
lgtm
4 years, 4 months ago (2016-07-27 15:30:06 UTC) #3
scheglov
LGTM
4 years, 4 months ago (2016-07-27 15:31:53 UTC) #4
pquitslund
4 years, 4 months ago (2016-07-27 16:17:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
da84692f578d7bc9f5173077155707f910d4d1ae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698