Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 218583013: Add effect for ellipse clipping. (Closed)

Created:
6 years, 8 months ago by bsalomon
Modified:
6 years, 8 months ago
Reviewers:
jvanverth1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add effect for ellipse clipping. BUG=skia:2181 Committed: http://code.google.com/p/skia/source/detail?r=14024

Patch Set 1 #

Patch Set 2 : rename var #

Patch Set 3 : Add check for divide by zero kills tile #

Patch Set 4 : fix extra param to appendf warning #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -3 lines) Patch
M src/gpu/effects/GrOvalEffect.cpp View 1 2 3 4 3 chunks +190 lines, -2 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
bsalomon
I don't know why all these other files are being uploaded to rietveld. Only GrOvalEffect.cpp ...
6 years, 8 months ago (2014-04-01 15:48:59 UTC) #1
jvanverth1
lgtm
6 years, 8 months ago (2014-04-01 17:29:40 UTC) #2
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 8 months ago (2014-04-01 20:35:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/218583013/60001
6 years, 8 months ago (2014-04-01 20:35:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/218583013/60001
6 years, 8 months ago (2014-04-01 21:33:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/218583013/60001
6 years, 8 months ago (2014-04-01 21:53:40 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 22:14:32 UTC) #7
commit-bot: I haz the power
Failed to apply the patch.
6 years, 8 months ago (2014-04-01 22:14:32 UTC) #8
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 8 months ago (2014-04-02 13:37:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/218583013/80001
6 years, 8 months ago (2014-04-02 13:37:39 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 15:00:47 UTC) #11
Message was sent while issue was closed. 
Change committed as 14024

Powered by Google App Engine
This is Rietveld 408576698