Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 218583007: Removed unused includes from UnicodeIcu.h (Closed)

Created:
6 years, 8 months ago by Dmitry Zvorygin
Modified:
6 years, 8 months ago
Reviewers:
Nico
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, abarth-chromium, danakj, Rik, adamk+blink_chromium.org, Inactive, Stephen Chennney, Mikhail, pdr., rwlbuis
Visibility:
Public.

Description

Removed unused includes from UnicodeIcu.h Speeds up blink compilation ~ 1.5% BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170466 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170542

Patch Set 1 #

Patch Set 2 : Fixed android compilation issue. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M Source/platform/fonts/FontCache.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M Source/platform/fonts/FontDescription.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/fonts/GenericFontFamilySettings.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/fonts/harfbuzz/HarfBuzzShaper.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/text/LocaleToScriptMapping.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/text/TextBreakIterator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/text/TextBreakIteratorICU.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/wtf/unicode/icu/UnicodeIcu.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Dmitry Zvorygin
Please take a look. As my tests say, this speedups blink compilation ~ 1.5%.
6 years, 8 months ago (2014-03-31 11:00:56 UTC) #1
Nico
lgtm! Maybe mention "Speeds up blink compilation ~ 1.5%" in the cl description.
6 years, 8 months ago (2014-03-31 16:18:16 UTC) #2
Dmitry Zvorygin
The CQ bit was checked by zvorygin@chromium.org
6 years, 8 months ago (2014-03-31 16:19:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zvorygin@chromium.org/218583007/1
6 years, 8 months ago (2014-03-31 16:19:26 UTC) #4
commit-bot: I haz the power
Change committed as 170466
6 years, 8 months ago (2014-03-31 17:25:54 UTC) #5
Dmitry Zvorygin
The CQ bit was checked by zvorygin@chromium.org
6 years, 8 months ago (2014-04-01 09:21:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zvorygin@chromium.org/218583007/20001
6 years, 8 months ago (2014-04-01 09:21:39 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 10:36:06 UTC) #8
Message was sent while issue was closed.
Change committed as 170542

Powered by Google App Engine
This is Rietveld 408576698