Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 218583004: Uprev to Polymer 0.2.1 (Closed)

Created:
6 years, 8 months ago by rsadam
Modified:
6 years, 8 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, raymes
Base URL:
https://chromium.googlesource.com/chromium/src.git@css-shadow
Visibility:
Public.

Description

The latest Blink roll deprecates HTMLImport API's used by Polymer 0.1.4. This patch uprevs to Polymer 0.2.1. BUG=347642, 357946 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261023

Patch Set 1 #

Patch Set 2 : Remove keyboard code from patch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+530 lines, -405 lines) Patch
M third_party/polymer/README.chromium View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/bower.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/polymer/platform/.bower.json View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/polymer/platform/bower.json View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/polymer/platform/build.log View 1 1 chunk +205 lines, -25 lines 0 comments Download
M third_party/polymer/platform/platform.js View 1 1 chunk +37 lines, -34 lines 0 comments Download
M third_party/polymer/polymer-selection/.bower.json View 1 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/polymer/polymer-selection/bower.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/polymer/polymer-selection/smoke.html View 1 1 chunk +0 lines, -47 lines 0 comments Download
M third_party/polymer/polymer-selector/.bower.json View 1 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/polymer/polymer-selector/bower.json View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/polymer/polymer-selector/polymer-selector.html View 1 4 chunks +19 lines, -2 lines 0 comments Download
D third_party/polymer/polymer-selector/smoke.html View 1 1 chunk +0 lines, -98 lines 0 comments Download
M third_party/polymer/polymer/.bower.json View 1 1 chunk +9 lines, -8 lines 0 comments Download
D third_party/polymer/polymer/AUTHORS View 1 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/polymer/polymer/CONTRIBUTING.md View 1 1 chunk +0 lines, -73 lines 0 comments Download
M third_party/polymer/polymer/LICENSE View 1 1 chunk +1 line, -1 line 0 comments Download
D third_party/polymer/polymer/PATENTS View 1 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/polymer/polymer/README.md View 1 1 chunk +5 lines, -15 lines 0 comments Download
M third_party/polymer/polymer/bower.json View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/polymer/polymer/build.log View 1 2 chunks +188 lines, -8 lines 0 comments Download
M third_party/polymer/polymer/polymer.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/polymer/polymer/polymer.js View 1 1 chunk +32 lines, -29 lines 0 comments Download
M third_party/polymer/polymer/polymer.js.map View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (0 generated)
rsadam
Kevers, PTAL!
6 years, 8 months ago (2014-03-30 16:08:54 UTC) #1
kevers
Thanks for taking care of this so quickly. lgtm
6 years, 8 months ago (2014-03-31 13:41:58 UTC) #2
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 8 months ago (2014-03-31 13:42:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/218583004/1
6 years, 8 months ago (2014-03-31 13:43:02 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-31 14:18:21 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=58536
6 years, 8 months ago (2014-03-31 14:18:22 UTC) #6
rsadam
+kalman for OWNERS
6 years, 8 months ago (2014-03-31 14:21:23 UTC) #7
not at google - send to devlin
lgtm
6 years, 8 months ago (2014-03-31 14:55:07 UTC) #8
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 8 months ago (2014-03-31 15:42:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/218583004/1
6 years, 8 months ago (2014-03-31 15:43:04 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-31 17:20:40 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-31 17:20:40 UTC) #12
rsadam
On 2014/03/31 17:20:40, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 8 months ago (2014-03-31 18:04:42 UTC) #13
dglazkov
On 2014/03/31 18:04:42, rsadam wrote: > On 2014/03/31 17:20:40, I haz the power (commit-bot) wrote: ...
6 years, 8 months ago (2014-03-31 18:26:04 UTC) #14
hayato
On 2014/03/31 18:26:04, dglazkov wrote: > On 2014/03/31 18:04:42, rsadam wrote: > > On 2014/03/31 ...
6 years, 8 months ago (2014-04-01 08:00:22 UTC) #15
yoshiki
On 2014/04/01 08:00:22, hayato wrote: > On 2014/03/31 18:26:04, dglazkov wrote: > > On 2014/03/31 ...
6 years, 8 months ago (2014-04-01 09:51:02 UTC) #16
yoshiki
The fix is committed. https://src.chromium.org/viewvc/chrome?revision=260846&view=revision Now, the audio player browsertests should succeed even with Polymer ...
6 years, 8 months ago (2014-04-01 14:41:44 UTC) #17
rsadam
Moved keyboard related changes into a different patch.
6 years, 8 months ago (2014-04-01 15:01:15 UTC) #18
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 8 months ago (2014-04-01 17:26:51 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/218583004/10001
6 years, 8 months ago (2014-04-01 17:27:58 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/218583004/10001
6 years, 8 months ago (2014-04-01 22:34:09 UTC) #21
commit-bot: I haz the power
Change committed as 261023
6 years, 8 months ago (2014-04-02 01:37:03 UTC) #22
hayato
6 years, 8 months ago (2014-04-02 03:53:12 UTC) #23
Message was sent while issue was closed.
The blink roll also includes https://codereview.chromium.org/218943003/, which
was reverted.

I confirmed that we can fix the failures of 'OpenAudioFiles/*' by adding the
following line A before including polymer's platform.js in
chrome/browser/resources/file_manager/audio_player/js/autio_player_script.js.

Element.prototype.webkitCreateShadowRoot = Element.prototype.createShadowRoot 
<-- (A)
<include src="../../../../../../third_party/polymer/platform/platform.js">

It seems we have to update third_party/polymer so that it does work without
webkitCreateShadowRoot so that we can land
https://codereview.chromium.org/218943003/ again.

Powered by Google App Engine
This is Rietveld 408576698