Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2422)

Unified Diff: chrome/browser/prefs/tracked/segregated_pref_store.cc

Issue 218583003: Separate storage for protected preferences into Protected Preferences file. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review comments. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/tracked/segregated_pref_store.cc
diff --git a/chrome/browser/prefs/tracked/segregated_pref_store.cc b/chrome/browser/prefs/tracked/segregated_pref_store.cc
index 5c51da9af003870b20b8304b43dc8a04d4abde06..13d5ecfaeedfa598de4bf57b29f3c87eb2897512 100644
--- a/chrome/browser/prefs/tracked/segregated_pref_store.cc
+++ b/chrome/browser/prefs/tracked/segregated_pref_store.cc
@@ -119,20 +119,20 @@ bool SegregatedPrefStore::ReadOnly() const {
PersistentPrefStore::PrefReadError SegregatedPrefStore::GetReadError() const {
PersistentPrefStore::PrefReadError read_error =
default_pref_store_->GetReadError();
- return read_error != PersistentPrefStore::PREF_READ_ERROR_NONE
- ? read_error
- : selected_pref_store_->GetReadError();
+ if (read_error == PersistentPrefStore::PREF_READ_ERROR_NONE) {
+ read_error = selected_pref_store_->GetReadError();
+ // Ignore NO_FILE from selected_pref_store_.
+ if (read_error == PersistentPrefStore::PREF_READ_ERROR_NO_FILE)
+ read_error = PersistentPrefStore::PREF_READ_ERROR_NONE;
+ }
+ return read_error;
}
PersistentPrefStore::PrefReadError SegregatedPrefStore::ReadPrefs() {
- PersistentPrefStore::PrefReadError unselected_read_error =
- default_pref_store_->ReadPrefs();
- PersistentPrefStore::PrefReadError selected_read_error =
- selected_pref_store_->ReadPrefs();
-
- return unselected_read_error != PersistentPrefStore::PREF_READ_ERROR_NONE
- ? unselected_read_error
- : selected_read_error;
+ default_pref_store_->ReadPrefs();
+ selected_pref_store_->ReadPrefs();
+
+ return GetReadError();
}
void SegregatedPrefStore::ReadPrefsAsync(ReadErrorDelegate* error_delegate) {

Powered by Google App Engine
This is Rietveld 408576698