content/renderer/gpu/queue_message_swap_promise.cc - Issue 2185823005: Make RenderViewImpl::OnForceRedraw more robust

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/gpu/queue_message_swap_promise.cc

Issue 2185823005: Make RenderViewImpl::OnForceRedraw more robust (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix comments and add tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/gpu/queue_message_swap_promise.cc

diff --git a/content/renderer/gpu/queue_message_swap_promise.cc b/content/renderer/gpu/queue_message_swap_promise.cc

index 8b99a17256c38cac5b7b3f69aa00d9d4eda3f9e4..377ca835f6184b34e3642a602d8107506e20f11b 100644

--- a/content/renderer/gpu/queue_message_swap_promise.cc

+++ b/content/renderer/gpu/queue_message_swap_promise.cc

@@ -66,7 +66,8 @@ void QueueMessageSwapPromise::DidSwap(cc::CompositorFrameMetadata* metadata) {

PromiseCompleted();

}

-void QueueMessageSwapPromise::DidNotSwap(DidNotSwapReason reason) {

+cc::SwapPromise::DidNotSwapAction QueueMessageSwapPromise::DidNotSwap(

+ DidNotSwapReason reason) {

#if DCHECK_IS_ON()

DCHECK(!completed_);

#endif

@@ -76,6 +77,7 @@ void QueueMessageSwapPromise::DidNotSwap(DidNotSwapReason reason) {

message_sender_->Send(msg.release());

}

PromiseCompleted();

+ return DidNotSwapAction::DEFAULT_ACTION;

}

void QueueMessageSwapPromise::PromiseCompleted() {