Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: content/renderer/render_view_impl.cc

Issue 2185823005: Make RenderViewImpl::OnForceRedraw more robust (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reimplemented using ForcedRedrawSwapPromise Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/trees/layer_tree_impl.cc ('K') | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 8ed17334975b79f18c5239932794bfc79f372ed8..ac58abe90b9cb14270011d5cc6bc742966f21cd5 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -37,6 +37,7 @@
#include "base/trace_event/trace_event.h"
#include "build/build_config.h"
#include "cc/base/switches.h"
+#include "cc/output/forced_redraw_swap_promise.h"
#include "content/child/appcache/appcache_dispatcher.h"
#include "content/child/appcache/web_application_cache_host_impl.h"
#include "content/child/child_shared_bitmap_manager.h"
@@ -1464,17 +1465,11 @@ void RenderViewImpl::ApplyWebPreferencesInternal(
ApplyWebPreferences(prefs, web_view);
}
-void RenderViewImpl::OnForceRedraw(int id) {
- ui::LatencyInfo latency_info;
- if (id) {
- latency_info.AddLatencyNumber(ui::WINDOW_SNAPSHOT_FRAME_NUMBER_COMPONENT,
- 0,
- id);
- }
- std::unique_ptr<cc::SwapPromiseMonitor> latency_info_swap_promise_monitor;
+void RenderViewImpl::OnForceRedraw(const ui::LatencyInfo& latency_info) {
if (RenderWidgetCompositor* rwc = compositor()) {
- latency_info_swap_promise_monitor =
- rwc->CreateLatencyInfoSwapPromiseMonitor(&latency_info);
+ std::unique_ptr<cc::SwapPromise> swap_promise(
+ new cc::ForcedRedrawSwapPromise(latency_info));
+ rwc->QueueSwapPromise(std::move(swap_promise));
}
ScheduleCompositeWithForcedRedraw();
}
« cc/trees/layer_tree_impl.cc ('K') | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698