Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2185823002: [ios] Fixed CRWWebControllerTest.WebUrlWithTrustLevel for iOS 10. (Closed)

Created:
4 years, 4 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 4 months ago
Reviewers:
Jackie Quinn
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Fixed CRWWebControllerTest.WebUrlWithTrustLevel for iOS 10. Stub |serverTrust| call instead of |certificateChain|. Test was broken by https://codereview.chromium.org/2151693008/ BUG=631577 Committed: https://crrev.com/763fe1a92b2409ec3dc1850416eba5db4da0d3c2 Cr-Commit-Position: refs/heads/master@{#407953}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M ios/web/web_state/ui/crw_web_controller_unittest.mm View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Eugene But (OOO till 7-30)
4 years, 4 months ago (2016-07-26 22:00:03 UTC) #4
Jackie Quinn
On 2016/07/26 22:00:03, Eugene But wrote: lgtm. Thanks for the quick fix!
4 years, 4 months ago (2016-07-26 22:02:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185823002/1
4 years, 4 months ago (2016-07-26 23:02:30 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 23:06:45 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 23:09:46 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/763fe1a92b2409ec3dc1850416eba5db4da0d3c2
Cr-Commit-Position: refs/heads/master@{#407953}

Powered by Google App Engine
This is Rietveld 408576698