Refactoring Canvas2DLayerBridge to make it easier to write unit tests

Refactoring Canvas2DLayerBridge to make it easier to write unit tests

This patch also adds a unit test that verifies graphics context loss handling.

BUG=267723
TEST=webkit_unit_tests --gtest_filter="*Canvas2D*"
R=jamesr

[Justin Novosad, 2013-08-02 20:11:26]

PTAL

Canvas2DLayerBridgeTestHelper.h is a new file, pay no attention to diff

[jamesr, 2013-08-05 22:56:36]

lgtm with some, although you should use the --simularity option to git cl to get
the metadata right

https://codereview.chromium.org/21858004/diff/1/Source/core/platform/graphics...
File Source/core/platform/graphics/ImageBuffer.cpp (right):

https://codereview.chromium.org/21858004/diff/1/Source/core/platform/graphics...
Source/core/platform/graphics/ImageBuffer.cpp:64: class AcceleratedLayerHelper :
public WebCore::Canvas2DLayerBridge::Helper {
put this anonymous namespace inside WebCore and you won't have to write
WebCore:: everywhere

https://codereview.chromium.org/21858004/diff/1/Source/core/platform/graphics...
File Source/core/platform/graphics/chromium/Canvas2DLayerBridge.cpp (right):

https://codereview.chromium.org/21858004/diff/1/Source/core/platform/graphics...
Source/core/platform/graphics/chromium/Canvas2DLayerBridge.cpp:246: if (texture)
{
early return on failure would make this function a lot shorter and avoid
changing the indentation on so many lines

https://codereview.chromium.org/21858004/diff/1/Source/core/platform/graphics...
File Source/core/platform/graphics/chromium/Canvas2DLayerBridgeTestHelper.h
(right):

https://codereview.chromium.org/21858004/diff/1/Source/core/platform/graphics...
Source/core/platform/graphics/chromium/Canvas2DLayerBridgeTestHelper.h:53:
virtual WTF::PassRefPtr<WebCore::GraphicsContext3D> getContext() OVERRIDE
You don't need WTF:: here (you basically never do, all the WTF headers for
common types have using statements that pull symbols into the global namespace)

https://codereview.chromium.org/21858004/diff/1/Source/core/tests/FakeWebGrap...
File Source/core/tests/FakeWebGraphicsContext3D.h (right):

https://codereview.chromium.org/21858004/diff/1/Source/core/tests/FakeWebGrap...
Source/core/tests/FakeWebGraphicsContext3D.h:267: void fakeContextLoss() {
m_isContextLost = true;}
keep a blank line before the 'protected:', please

[jamesr, 2013-08-05 22:56:57]

Also typo in description 'varifies' -> 'verifies'

[commit-bot: I haz the power, 2013-08-06 18:10:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/junov@chromium.org/21858004/10001

[commit-bot: I haz the power, 2013-08-06 18:37:34]

Retried try job too often on linux_blink_rel for step(s) webkit_tests,
webkit_unit_tests, weborigin_unittests, wtf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[commit-bot: I haz the power, 2013-08-06 19:54:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/junov@chromium.org/21858004/23001

[commit-bot: I haz the power, 2013-08-06 20:28:14]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_layout.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-08-06 21:26:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/junov@chromium.org/21858004/33001

[commit-bot: I haz the power, 2013-08-06 23:15:31]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...