[Offline Page]Add file-path in java side OfflinePageItem

Add file-path in java side OfflinePageItem

Enables getting the file-path of offline page item from java side code. Will be used in Issue 2081153005.

BUG=622139
Committed: https://crrev.com/727acc0277b64bb902c8fdaf238ba438878a88b2
Cr-Commit-Position: refs/heads/master@{#407942}

[Vivian, 2016-07-26 20:43:32]

Description was changed from

==========
Add file-path in java side OfflinePageItem

BUG=622139
==========

to

==========
Add file-path in java side OfflinePageItem

Enables getting the file-path of offline page item from java side code. Will be
used in Issue 2081153005.

BUG=622139
==========

[Vivian, 2016-07-26 20:45:11]

weiran@google.com changed reviewers:
+ dewittj@chromium.org, fgorski@chromium.org, tedchoc@chromium.org

[Vivian, 2016-07-26 20:45:12]

ptal

[fgorski, 2016-07-26 20:52:00]

lgtm

[dewittj, 2016-07-26 21:13:58]

https://codereview.chromium.org/2185783002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageItem.java
(right):

https://codereview.chromium.org/2185783002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageItem.java:57:
public String getOfflineUrl() {
Is mOfflineUrl redundant now?  Can we generate that from the file path?

[fgorski, 2016-07-26 21:27:55]

On 2016/07/26 21:13:58, dewittj wrote:
>
https://codereview.chromium.org/2185783002/diff/1/chrome/android/java/src/org...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageItem.java
> (right):
> 
>
https://codereview.chromium.org/2185783002/diff/1/chrome/android/java/src/org...
>
chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageItem.java:57:
> public String getOfflineUrl() {
> Is mOfflineUrl redundant now?  Can we generate that from the file path?

Tooling for that is very appropriate on C++ side. I don't think we should try to
add the same code on Java side.

[dewittj, 2016-07-26 21:35:48]

On 2016/07/26 21:27:55, fgorski wrote:
> On 2016/07/26 21:13:58, dewittj wrote:
> >
>
https://codereview.chromium.org/2185783002/diff/1/chrome/android/java/src/org...
> > File
> >
>
chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageItem.java
> > (right):
> > 
> >
>
https://codereview.chromium.org/2185783002/diff/1/chrome/android/java/src/org...
> >
>
chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageItem.java:57:
> > public String getOfflineUrl() {
> > Is mOfflineUrl redundant now?  Can we generate that from the file path?
> 
> Tooling for that is very appropriate on C++ side. I don't think we should try
to
> add the same code on Java side.

OK, lgtm

[Vivian, 2016-07-26 21:37:39]

The CQ bit was checked by weiran@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 21:38:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 22:29:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 22:29:45]

Dry run: This issue passed the CQ dry run.

[Vivian, 2016-07-26 22:32:20]

weiran@google.com changed reviewers:
- tedchoc@chromium.org

[Vivian, 2016-07-26 22:32:30]

The CQ bit was checked by weiran@google.com

[commit-bot: I haz the power, 2016-07-26 22:33:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 22:39:12]

Description was changed from

==========
Add file-path in java side OfflinePageItem

Enables getting the file-path of offline page item from java side code. Will be
used in Issue 2081153005.

BUG=622139
==========

to

==========
Add file-path in java side OfflinePageItem

Enables getting the file-path of offline page item from java side code. Will be
used in Issue 2081153005.

BUG=622139
==========

[commit-bot: I haz the power, 2016-07-26 22:39:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-26 22:42:23]

Description was changed from

==========
Add file-path in java side OfflinePageItem

Enables getting the file-path of offline page item from java side code. Will be
used in Issue 2081153005.

BUG=622139
==========

to

==========
Add file-path in java side OfflinePageItem

Enables getting the file-path of offline page item from java side code. Will be
used in Issue 2081153005.

BUG=622139

Committed: https://crrev.com/727acc0277b64bb902c8fdaf238ba438878a88b2
Cr-Commit-Position: refs/heads/master@{#407942}
==========

[commit-bot: I haz the power, 2016-07-26 22:42:24]

Patchset 1 (id:??) landed as
https://crrev.com/727acc0277b64bb902c8fdaf238ba438878a88b2
Cr-Commit-Position: refs/heads/master@{#407942}