Refactor: remove SetDisplayWorkAreaInsets calls.

Refactor: remove SetDisplayWorkAreaInsets calls.

Use DisplayObserver's OnDisplayMetricsChanged instead when work area is
changed.

BUG=631557
Committed: https://crrev.com/c42e8f5758b28d3da954b86692f5a4f22707d212
Cr-Commit-Position: refs/heads/master@{#408507}

[hariank, 2016-07-26 19:23:05]

Description was changed from

==========
Refactor: remove SetDisplayWorkAreaInsets calls.

Use DisplayObserver's OnDisplayMetricsChanged instead when work area is
changed.

BUG=631557
==========

to

==========
Refactor: remove SetDisplayWorkAreaInsets calls.

Use DisplayObserver's OnDisplayMetricsChanged instead when work area is
changed.

BUG=631557
==========

[hariank, 2016-07-26 19:23:05]

hariank@google.com changed reviewers:
+ oshima@chromium.org

[oshima, 2016-07-26 20:42:56]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 20:43:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oshima, 2016-07-26 20:53:03]

looks good, just nits + one question in the test.

https://codereview.chromium.org/2185773002/diff/1/ash/aura/wm_root_window_con...
File ash/aura/wm_root_window_controller_aura.cc (right):

https://codereview.chromium.org/2185773002/diff/1/ash/aura/wm_root_window_con...
ash/aura/wm_root_window_controller_aura.cc:170: const display::Display& display)
{}
nit: please keep the same order as in the header.

https://codereview.chromium.org/2185773002/diff/1/ash/display/display_manager.cc
File ash/display/display_manager.cc (right):

https://codereview.chromium.org/2185773002/diff/1/ash/display/display_manager...
ash/display/display_manager.cc:292: if (old_work_area != display->work_area()) {
nit:

bool workarea_changed = old_work_area != display->work_area();
if (workarea_chanaged) {
   ....
}
return workarea_changed;

https://codereview.chromium.org/2185773002/diff/1/ash/display/display_manager...
File ash/display/display_manager_unittest.cc (right):

https://codereview.chromium.org/2185773002/diff/1/ash/display/display_manager...
ash/display/display_manager_unittest.cc:164:
EXPECT_EQ(display_manager()->GetDisplayAt(0).id(), changed()[1].id());
can you check ids for both displays?

https://codereview.chromium.org/2185773002/diff/1/ash/display/display_manager...
ash/display/display_manager_unittest.cc:166: EXPECT_EQ("0,0 500x500",
changed()[1].bounds().ToString());
ditto

https://codereview.chromium.org/2185773002/diff/1/ash/display/display_manager...
ash/display/display_manager_unittest.cc:188: EXPECT_EQ("1 1 0",
GetCountSummary());
check the id of the changed display.

https://codereview.chromium.org/2185773002/diff/1/ash/display/display_manager...
ash/display/display_manager_unittest.cc:306:
EXPECT_EQ(display_manager()->GetDisplayAt(0).id(), changed()[2].id());
ditto

https://codereview.chromium.org/2185773002/diff/1/ash/display/display_manager...
ash/display/display_manager_unittest.cc:309: EXPECT_EQ("0,0 640x480",
changed()[2].bounds().ToString());
ditto

https://codereview.chromium.org/2185773002/diff/1/ash/display/window_tree_hos...
File ash/display/window_tree_host_manager_unittest.cc (right):

https://codereview.chromium.org/2185773002/diff/1/ash/display/window_tree_hos...
ash/display/window_tree_host_manager_unittest.cc:439: EXPECT_EQ(2,
observer.GetWorkareaChangedCountAndReset());
I didn't expect this will change because moving the window should update the
workarea at the same time. Do you know how the 2nd one gets triggered?

[commit-bot: I haz the power, 2016-07-26 21:33:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 21:33:02]

Dry run: This issue passed the CQ dry run.

[hariank, 2016-07-26 22:05:16]

https://codereview.chromium.org/2185773002/diff/1/ash/aura/wm_root_window_con...
File ash/aura/wm_root_window_controller_aura.cc (right):

https://codereview.chromium.org/2185773002/diff/1/ash/aura/wm_root_window_con...
ash/aura/wm_root_window_controller_aura.cc:170: const display::Display& display)
{}
On 2016/07/26 20:53:03, oshima wrote:
> nit: please keep the same order as in the header.

Done.

https://codereview.chromium.org/2185773002/diff/1/ash/display/display_manager.cc
File ash/display/display_manager.cc (right):

https://codereview.chromium.org/2185773002/diff/1/ash/display/display_manager...
ash/display/display_manager.cc:292: if (old_work_area != display->work_area()) {
On 2016/07/26 20:53:03, oshima wrote:
> nit:
> 
> bool workarea_changed = old_work_area != display->work_area();
> if (workarea_chanaged) {
>    ....
> }
> return workarea_changed;
> 

Done.

https://codereview.chromium.org/2185773002/diff/1/ash/display/display_manager...
File ash/display/display_manager_unittest.cc (right):

https://codereview.chromium.org/2185773002/diff/1/ash/display/display_manager...
ash/display/display_manager_unittest.cc:164:
EXPECT_EQ(display_manager()->GetDisplayAt(0).id(), changed()[1].id());
On 2016/07/26 20:53:03, oshima wrote:
> can you check ids for both displays?

Done.

https://codereview.chromium.org/2185773002/diff/1/ash/display/display_manager...
ash/display/display_manager_unittest.cc:166: EXPECT_EQ("0,0 500x500",
changed()[1].bounds().ToString());
On 2016/07/26 20:53:03, oshima wrote:
> ditto

Done.

https://codereview.chromium.org/2185773002/diff/1/ash/display/display_manager...
ash/display/display_manager_unittest.cc:188: EXPECT_EQ("1 1 0",
GetCountSummary());
On 2016/07/26 20:53:03, oshima wrote:
> check the id of the changed display.

Done.

https://codereview.chromium.org/2185773002/diff/1/ash/display/display_manager...
ash/display/display_manager_unittest.cc:306:
EXPECT_EQ(display_manager()->GetDisplayAt(0).id(), changed()[2].id());
On 2016/07/26 20:53:03, oshima wrote:
> ditto

Done.

https://codereview.chromium.org/2185773002/diff/1/ash/display/display_manager...
ash/display/display_manager_unittest.cc:309: EXPECT_EQ("0,0 640x480",
changed()[2].bounds().ToString());
On 2016/07/26 20:53:03, oshima wrote:
> ditto

Done.

https://codereview.chromium.org/2185773002/diff/1/ash/display/window_tree_hos...
File ash/display/window_tree_host_manager_unittest.cc (right):

https://codereview.chromium.org/2185773002/diff/1/ash/display/window_tree_hos...
ash/display/window_tree_host_manager_unittest.cc:439: EXPECT_EQ(2,
observer.GetWorkareaChangedCountAndReset());
On 2016/07/26 20:53:03, oshima wrote:
> I didn't expect this will change because moving the window should update the
> workarea at the same time. Do you know how the 2nd one gets triggered?

added todo

[hariank, 2016-07-26 22:06:13]

The CQ bit was checked by hariank@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 22:06:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oshima, 2016-07-26 22:11:21]

lgtm

thanks!

[hariank, 2016-07-26 22:20:18]

The CQ bit was unchecked by hariank@google.com

[hariank, 2016-07-26 22:20:19]

The CQ bit was checked by hariank@google.com

[commit-bot: I haz the power, 2016-07-26 22:20:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 22:27:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 22:27:29]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hariank, 2016-07-26 22:36:41]

hariank@google.com changed reviewers:
+ reveman@chromium.org

[reveman, 2016-07-28 22:14:26]

lgtm

[hariank, 2016-07-28 22:28:21]

The CQ bit was checked by hariank@google.com

[commit-bot: I haz the power, 2016-07-28 22:28:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 23:50:49]

Description was changed from

==========
Refactor: remove SetDisplayWorkAreaInsets calls.

Use DisplayObserver's OnDisplayMetricsChanged instead when work area is
changed.

BUG=631557
==========

to

==========
Refactor: remove SetDisplayWorkAreaInsets calls.

Use DisplayObserver's OnDisplayMetricsChanged instead when work area is
changed.

BUG=631557
==========

[commit-bot: I haz the power, 2016-07-28 23:50:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-28 23:53:04]

Description was changed from

==========
Refactor: remove SetDisplayWorkAreaInsets calls.

Use DisplayObserver's OnDisplayMetricsChanged instead when work area is
changed.

BUG=631557
==========

to

==========
Refactor: remove SetDisplayWorkAreaInsets calls.

Use DisplayObserver's OnDisplayMetricsChanged instead when work area is
changed.

BUG=631557

Committed: https://crrev.com/c42e8f5758b28d3da954b86692f5a4f22707d212
Cr-Commit-Position: refs/heads/master@{#408507}
==========

[commit-bot: I haz the power, 2016-07-28 23:53:08]

Patchset 2 (id:??) landed as
https://crrev.com/c42e8f5758b28d3da954b86692f5a4f22707d212
Cr-Commit-Position: refs/heads/master@{#408507}