Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2185773002: Refactor: remove SetDisplayWorkAreaInsets calls. (Closed)

Created:
4 years, 4 months ago by hariank
Modified:
4 years, 4 months ago
Reviewers:
reveman, oshima
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor: remove SetDisplayWorkAreaInsets calls. Use DisplayObserver's OnDisplayMetricsChanged instead when work area is changed. BUG=631557 Committed: https://crrev.com/c42e8f5758b28d3da954b86692f5a4f22707d212 Cr-Commit-Position: refs/heads/master@{#408507}

Patch Set 1 #

Total comments: 16

Patch Set 2 : Refactor: remove SetDisplayWorkAreaInsets calls. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -37 lines) Patch
M ash/aura/wm_root_window_controller_aura.h View 3 chunks +9 lines, -2 lines 0 comments Download
M ash/aura/wm_root_window_controller_aura.cc View 1 4 chunks +17 lines, -6 lines 0 comments Download
M ash/common/shell_observer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/common/system/web_notification/ash_popup_alignment_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/common/system/web_notification/ash_popup_alignment_delegate.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ash/display/display_manager.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M ash/display/display_manager_unittest.cc View 1 5 chunks +16 lines, -9 lines 0 comments Download
M ash/display/window_tree_host_manager_unittest.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M ash/shell.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/exo/wayland/server.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 25 (15 generated)
oshima
looks good, just nits + one question in the test. https://codereview.chromium.org/2185773002/diff/1/ash/aura/wm_root_window_controller_aura.cc File ash/aura/wm_root_window_controller_aura.cc (right): https://codereview.chromium.org/2185773002/diff/1/ash/aura/wm_root_window_controller_aura.cc#newcode170 ...
4 years, 4 months ago (2016-07-26 20:53:03 UTC) #5
hariank
https://codereview.chromium.org/2185773002/diff/1/ash/aura/wm_root_window_controller_aura.cc File ash/aura/wm_root_window_controller_aura.cc (right): https://codereview.chromium.org/2185773002/diff/1/ash/aura/wm_root_window_controller_aura.cc#newcode170 ash/aura/wm_root_window_controller_aura.cc:170: const display::Display& display) {} On 2016/07/26 20:53:03, oshima wrote: ...
4 years, 4 months ago (2016-07-26 22:05:16 UTC) #8
oshima
lgtm thanks!
4 years, 4 months ago (2016-07-26 22:11:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185773002/20001
4 years, 4 months ago (2016-07-26 22:20:27 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/225629)
4 years, 4 months ago (2016-07-26 22:27:29 UTC) #16
hariank
4 years, 4 months ago (2016-07-28 22:05:30 UTC) #18
reveman
lgtm
4 years, 4 months ago (2016-07-28 22:14:26 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185773002/20001
4 years, 4 months ago (2016-07-28 22:28:36 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-28 23:50:50 UTC) #23
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 23:53:08 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c42e8f5758b28d3da954b86692f5a4f22707d212
Cr-Commit-Position: refs/heads/master@{#408507}

Powered by Google App Engine
This is Rietveld 408576698