Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2185733002: Don't remove DistillabilityService on RenderFrameHost switch (Closed)

Created:
4 years, 4 months ago by mdjones
Modified:
4 years, 4 months ago
Reviewers:
wychen
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't remove DistillabilityService on RenderFrameHost switch If the RenderFrameHost is swapped, it usually means the old host will be destroyed. Manual cleanup of the mojo service should not be necessary since the attached interfaces will be removed during destruction. BUG=624260 Committed: https://crrev.com/79d8c296af57ac0fc54f887847dc131aea525a61 Cr-Commit-Position: refs/heads/master@{#408244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M components/dom_distiller/content/browser/distillability_driver.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mdjones
ptal
4 years, 4 months ago (2016-07-26 17:20:38 UTC) #2
wychen
lgtm
4 years, 4 months ago (2016-07-26 17:25:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185733002/1
4 years, 4 months ago (2016-07-27 20:50:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 21:35:03 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 21:36:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79d8c296af57ac0fc54f887847dc131aea525a61
Cr-Commit-Position: refs/heads/master@{#408244}

Powered by Google App Engine
This is Rietveld 408576698