Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: ipc/ipc_mojo_bootstrap.cc

Issue 2185723002: Eliminate deferred destruction of AssociatedGroupController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/public/cpp/bindings/associated_group_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_mojo_bootstrap.cc
diff --git a/ipc/ipc_mojo_bootstrap.cc b/ipc/ipc_mojo_bootstrap.cc
index 21e7ca379dc3640cafb8746f7ba8ecbd2d78fd07..e253039e9f336df22dd25869c97dfefc872d6358 100644
--- a/ipc/ipc_mojo_bootstrap.cc
+++ b/ipc/ipc_mojo_bootstrap.cc
@@ -48,8 +48,7 @@ class ChannelAssociatedGroupController
ChannelAssociatedGroupController(
bool set_interface_id_namespace_bit,
const scoped_refptr<base::SingleThreadTaskRunner>& ipc_task_runner)
- : mojo::AssociatedGroupController(base::ThreadTaskRunnerHandle::Get()),
- task_runner_(ipc_task_runner),
+ : task_runner_(ipc_task_runner),
proxy_task_runner_(base::ThreadTaskRunnerHandle::Get()),
set_interface_id_namespace_bit_(set_interface_id_namespace_bit),
header_validator_(
@@ -345,6 +344,8 @@ class ChannelAssociatedGroupController
};
~ChannelAssociatedGroupController() override {
+ DCHECK(!connector_);
+
base::AutoLock locker(lock_);
for (auto iter = endpoints_.begin(); iter != endpoints_.end();) {
Endpoint* endpoint = iter->second.get();
« no previous file with comments | « no previous file | mojo/public/cpp/bindings/associated_group_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698