Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2185703003: Switch on use_new_wrapper_types mode for content/shell and content/test. (Closed)

Created:
4 years, 4 months ago by leonhsl(Using Gerrit)
Modified:
4 years, 4 months ago
Reviewers:
Mike West, yzshen1, sky
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, ortuno+watch_chromium.org, Peter Beverloo, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch on use_new_wrapper_types mode for content/shell and content/test. BUG=624136 TBR=sky@chromium.org Committed: https://crrev.com/02c20546e12a3cc80372ce35050afe05cc1faeab Cr-Commit-Position: refs/heads/master@{#408593}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M content/content_shell.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_bluetooth_fake_adapter_setter_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_bluetooth_fake_adapter_setter_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
leonhsl(Using Gerrit)
I planned to switch on use_new_wrapper_types for content/ overall with one CL, but it's supposed ...
4 years, 4 months ago (2016-07-28 02:05:43 UTC) #6
Mike West
//content/shell LGTM.
4 years, 4 months ago (2016-07-28 09:15:08 UTC) #7
yzshen1
lgtm
4 years, 4 months ago (2016-07-28 18:27:33 UTC) #8
leonhsl(Using Gerrit)
Thanks all~ Because of only trivial change for content/test, and seems sky is OOO, let ...
4 years, 4 months ago (2016-07-29 04:40:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185703003/1
4 years, 4 months ago (2016-07-29 04:43:11 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 06:54:11 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/02c20546e12a3cc80372ce35050afe05cc1faeab Cr-Commit-Position: refs/heads/master@{#408593}
4 years, 4 months ago (2016-07-29 06:56:12 UTC) #15
sky
4 years, 4 months ago (2016-08-01 22:35:19 UTC) #16
Message was sent while issue was closed.
content/test LGTM

Powered by Google App Engine
This is Rietveld 408576698