Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2185693004: Add baxley as OWNER of ios Earl Grey test code. (Closed)

Created:
4 years, 4 months ago by baxley
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add baxley as OWNER of ios Earl Grey test code. BUG= Committed: https://crrev.com/40b656ba0b31efa9747fcdf4aad3c0385b979591 Cr-Commit-Position: refs/heads/master@{#408276}

Patch Set 1 #

Total comments: 1

Patch Set 2 : add eugenebut for ios/web/public/test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
A ios/testing/earl_grey/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A + ios/web/public/test/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
A ios/web/shell/test/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
baxley
4 years, 4 months ago (2016-07-27 22:25:21 UTC) #2
Eugene But (OOO till 7-30)
lgtm
4 years, 4 months ago (2016-07-27 22:45:23 UTC) #5
Eugene But (OOO till 7-30)
https://codereview.chromium.org/2185693004/diff/1/ios/web/public/test/OWNERS File ios/web/public/test/OWNERS (right): https://codereview.chromium.org/2185693004/diff/1/ios/web/public/test/OWNERS#newcode1 ios/web/public/test/OWNERS:1: baxley@chromium.org Please add me to this list as well
4 years, 4 months ago (2016-07-27 22:46:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185693004/20001
4 years, 4 months ago (2016-07-27 22:55:52 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-27 23:40:17 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 23:41:33 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/40b656ba0b31efa9747fcdf4aad3c0385b979591
Cr-Commit-Position: refs/heads/master@{#408276}

Powered by Google App Engine
This is Rietveld 408576698