Adding an It2Me host binary which is uiaccess enabled.

Adding an It2Me host binary which is uiaccess enabled.

This binary will be used by the non-elevated It2Me process to allow the remote
user to interact with higher UIPI level windows on the desktop.

BUG=617185
Committed: https://crrev.com/f9f0423abeb242dd3c23bbd44655a2a2a513e392
Cr-Commit-Position: refs/heads/master@{#414837}

[joedow, 2016-07-27 03:54:17]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 03:54:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 04:57:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 04:57:49]

Dry run: This issue passed the CQ dry run.

[joedow, 2016-07-28 01:54:32]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 01:54:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 02:02:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 02:03:00]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[joedow, 2016-07-28 02:24:49]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 02:25:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 03:19:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 03:19:11]

Dry run: This issue passed the CQ dry run.

[joedow, 2016-08-25 16:39:24]

The CQ bit was checked by joedow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 16:40:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[joedow, 2016-08-25 16:42:32]

joedow@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[joedow, 2016-08-25 16:42:32]

Hi Jamie,

This change adds the UiAccess enabled It2Me binary to our build and package.  I
would like to get started with some of the CLs for the It2Me work since there is
quite a bit and getting the binary in place will help with that.

I do not plan to check this in for M54, I will wait until after the branch point
if the change is LGTM'd sooner.

PTAL!

Thanks,
Joe

[joedow, 2016-08-25 16:44:09]

Please also note, the GYP changes are there because I started this work prior to
the GN switch-over.  They should be benign since GYP isn't used anymore but I
can remove them if you'd prefer.

[commit-bot: I haz the power, 2016-08-25 17:51:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 17:51:14]

Dry run: This issue passed the CQ dry run.

[Jamie, 2016-08-26 00:29:47]

I think as long as the gyp file exists, it should be kept in sync as you've done
here. We should remove it eventually though.

LGTM if my suggestion of not building the uiacess target for unsigned builds is
not a good one; otherwise I'll take another look.

https://codereview.chromium.org/2185693003/diff/60001/remoting/host/it2me/BUI...
File remoting/host/it2me/BUILD.gn (right):

https://codereview.chromium.org/2185693003/diff/60001/remoting/host/it2me/BUI...
remoting/host/it2me/BUILD.gn:101: if (is_official_build) {
Would it be better to only build this target for an official build? Otherwise
don't you end up with two identical binaries, one of which has a misleading
name?

[joedow, 2016-08-26 18:28:52]

Thanks!

https://codereview.chromium.org/2185693003/diff/60001/remoting/host/it2me/BUI...
File remoting/host/it2me/BUILD.gn (right):

https://codereview.chromium.org/2185693003/diff/60001/remoting/host/it2me/BUI...
remoting/host/it2me/BUILD.gn:101: if (is_official_build) {
On 2016/08/26 00:29:47, Jamie wrote:
> Would it be better to only build this target for an official build? Otherwise
> don't you end up with two identical binaries, one of which has a misleading
> name?

My thought on this was that it is better to build the binary so we can test the
IPC mechanism and using multiple processes w/o requiring a signed build. 
Signing is kind of a pain so we can get a fair amount of benefits for iterative
development and the only downside is that the binary won't actually have
UiAccess.  I think this is worth it (it has been so far for me as I make
changes).

We do something similar for remoting_desktop as well where we only apply the
manifest fragment if it is an official, signed build.

[joedow, 2016-08-26 18:28:56]

The CQ bit was checked by joedow@chromium.org

[joedow, 2016-08-26 18:28:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/2185693003/#ps80001
(title: "Merging!")

[commit-bot: I haz the power, 2016-08-26 18:30:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 21:20:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 21:20:52]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[joedow, 2016-08-26 21:21:39]

The CQ bit was checked by joedow@chromium.org

[commit-bot: I haz the power, 2016-08-26 21:23:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 22:39:53]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-26 22:43:20]

Description was changed from

==========
Adding an It2Me host binary which is uiaccess enabled.

This binary will be used by the non-elevated It2Me process to allow the remote
user to interact with higher UIPI level windows on the desktop.

BUG=617185
==========

to

==========
Adding an It2Me host binary which is uiaccess enabled.

This binary will be used by the non-elevated It2Me process to allow the remote
user to interact with higher UIPI level windows on the desktop.

BUG=617185

Committed: https://crrev.com/f9f0423abeb242dd3c23bbd44655a2a2a513e392
Cr-Commit-Position: refs/heads/master@{#414837}
==========

[commit-bot: I haz the power, 2016-08-26 22:43:22]

Patchset 5 (id:??) landed as
https://crrev.com/f9f0423abeb242dd3c23bbd44655a2a2a513e392
Cr-Commit-Position: refs/heads/master@{#414837}