gerrit_api: add on_behalf_of to set_review method.

infra/libs/gerrit_api/gerrit_api.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Yet another wrapper around Gerrit REST API."""
 
 import base64
 import cookielib
 import functools
 import json
@@ skipping 411 matching lines @@
     code, body = self._request(method='GET', request_path=request_path,
                                params=params)
     if code == 404:
       return None
     if code != 200:
       raise UnexpectedResponseException(code, body)
     return body
 
   @_not_read_only
   def set_review(self, change_id, revision_id, message=None, labels=None,
-                 notify=NOTIFY_NONE, max_message=300, tag=None):
+                 notify=NOTIFY_NONE, max_message=300, tag=None,
+                 on_behalf_of=None):
     """Uses the Set Review endpoint of the Gerrit API to add messages and/or set
     labels for a patchset.
+
     Documentation:
     https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#set-review
 
     Args:
       change_id: (str) The id of the change list.
       revision_id: (str) The id of the affected revision.
       message: (str) The message to add to the patchset.
       labels: (dict) The dictionary which maps label names to their new value.
       notify: (str) Who should get a notification.
-      tag: (str) Apply this tag to the review comment message and labels(votes):
+      tag: (str) Apply this tag to the review comment message and labels (votes)
         https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#review-input
+      on_behalf_of: (str) The account_id of the user on whose behalf to set
+        labels.
     """
     if message:
       tail = u'\n(message too large)'
       if len(message) > max_message:
         message = message[:max_message-len(tail)] + tail # pragma: no cover
       logging.info('change_id: %s; comment: %s' % (change_id, message.strip()))
     payload = {}
     for var, attr in [(message, 'message'), (notify, 'notify'),
-                      (labels, 'labels'), (tag, 'tag')]:
+                     (labels, 'labels'), (tag, 'tag'),
+                     (on_behalf_of, 'on_behalf_of')]:
       if var is not None:
         payload[attr] = var
     code, body = self._request(
         method='POST',
         request_path='/changes/%s/revisions/%s/review' % (
             urllib.quote(change_id, safe='~'),
             urllib.quote(revision_id, safe='')),
         body=payload)
     if code != 200:
       raise UnexpectedResponseException(code, body)
@@ skipping 31 matching lines @@
   Returns:
     is_cached (bool):
   """
   if method != 'GET':
     return False # pragma: no cover
   try:
     cache = requests_cache.get_cache()
   except AttributeError: # pragma: no cover
     cache = None
   return cache.has_url(full_url) if cache else False