Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: test/cctest/heap/test-heap.cc

Issue 2185613002: [heap] Reland "Remove black pages and use black areas instead." (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: move check to left trimming Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects-inl.h ('k') | test/unittests/heap/marking-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/heap/test-heap.cc
diff --git a/test/cctest/heap/test-heap.cc b/test/cctest/heap/test-heap.cc
index aa2b704ca7c2d04ee2bf0c6210bbfea97513ab83..8f8c7061652ae35d3c6b741d39d049912398217d 100644
--- a/test/cctest/heap/test-heap.cc
+++ b/test/cctest/heap/test-heap.cc
@@ -6787,6 +6787,43 @@ TEST(Regress615489) {
CHECK_LE(size_after, size_before);
}
+TEST(LeftTrimFixedArrayInBlackArea) {
+ FLAG_black_allocation = true;
+ CcTest::InitializeVM();
+ v8::HandleScope scope(CcTest::isolate());
+ Heap* heap = CcTest::heap();
+ Isolate* isolate = heap->isolate();
+ heap->CollectAllGarbage();
+
+ i::MarkCompactCollector* collector = heap->mark_compact_collector();
+ i::IncrementalMarking* marking = heap->incremental_marking();
+ if (collector->sweeping_in_progress()) {
+ collector->EnsureSweepingCompleted();
+ }
+ CHECK(marking->IsMarking() || marking->IsStopped());
+ if (marking->IsStopped()) {
+ heap->StartIncrementalMarking();
+ }
+ CHECK(marking->IsMarking());
+ marking->StartBlackAllocationForTesting();
+
+ // Ensure that we allocate a new page, set up a bump pointer area, and
+ // perform the allocation in a black area.
+ heap::SimulateFullSpace(heap->old_space());
+ isolate->factory()->NewFixedArray(4, TENURED);
+ Handle<FixedArray> array = isolate->factory()->NewFixedArray(50, TENURED);
+ CHECK(heap->old_space()->Contains(*array));
+ CHECK(Marking::IsBlack(ObjectMarking::MarkBitFrom(*array)));
+
+ // Now left trim the allocated black area. A filler has to be installed
+ // for the trimmed area and all mark bits of the trimmed area have to be
+ // cleared.
+ FixedArrayBase* trimmed = heap->LeftTrimFixedArray(*array, 10);
+ CHECK(Marking::IsBlack(ObjectMarking::MarkBitFrom(trimmed)));
+
+ heap::GcAndSweep(heap, OLD_SPACE);
+}
+
TEST(Regress618958) {
CcTest::InitializeVM();
v8::HandleScope scope(CcTest::isolate());
« no previous file with comments | « src/objects-inl.h ('k') | test/unittests/heap/marking-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698