Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2185533007:
Fix spurious WebRTC test failure on certain IPv6 networks (Closed)
|
Created:
4 years, 4 months ago by skvlad-chromium Modified:
4 years, 4 months ago Reviewers:
honghaiz, pthatcher2, ehmaldonado_webrtc, Taylor_Brandstetter, ehmaldonado_chromium, jiayl CC:
chromium-reviews, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix spurious WebRTC test failure on certain IPv6 networks
A helper function that determines whether an IP address is loopback was
checking for a "::1" substring in the IP address. Non-loopback IPv6
addresses can have that substring - e.g. "1234::1234:1234". If the test
runs on a machine with one of these addresses, it would fail
erroneously.
The fix simply adds spaces on both sides of the pattern, so that it only
matches complete IP addresses (always surrounded by spaces in an ICE
candidate line).
BUG=629705
Committed: https://crrev.com/60b186ed1accde051b06bf74b966a88ec9b54fba
Cr-Commit-Position: refs/heads/master@{#408726}
Patch Set 1 #
Messages
Total messages: 28 (14 generated)
Description was changed from ========== Fix spurious WebRTC test failure on certain IPv6 networks A helper function that determines whether an IP address is loopback was checking for a "::1" substring in the IP address. Non-loopback IPv6 addresses can have that substring - e.g. "1234::1234:1234". If the test runs on a machine with one of these addresses, it would fail erroneously. The fix simply adds spaces on both sides of the pattern, so that it only matches complete IP addresses (always surrounded by spaces in an ICE candidate line). BUG=629705 ========== to ========== Fix spurious WebRTC test failure on certain IPv6 networks A helper function that determines whether an IP address is loopback was checking for a "::1" substring in the IP address. Non-loopback IPv6 addresses can have that substring - e.g. "1234::1234:1234". If the test runs on a machine with one of these addresses, it would fail erroneously. The fix simply adds spaces on both sides of the pattern, so that it only matches complete IP addresses (always surrounded by spaces in an ICE candidate line). BUG=629705 ==========
skvlad@chromium.org changed reviewers: + deadbeef@chromium.org, ehmaldonado@chromium.org
lgtm lgtm
skvlad@chromium.org changed reviewers: + honghaiz@chromium.org
pthatcher@chromium.org changed reviewers: + pthatcher@chromium.org
lgtm
The CQ bit was checked by skvlad@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
skvlad@chromium.org changed reviewers: + jiayl@chromium.org
ehmaldonado@, jiayl@ - could one of you please approve this change? A Chromium committer needs to do it.
On 2016/07/29 00:32:54, skvlad1 wrote: > ehmaldonado@, jiayl@ - could one of you please approve this change? A Chromium > committer needs to do it. lgtm
lgtm
The CQ bit was checked by skvlad@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by skvlad@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix spurious WebRTC test failure on certain IPv6 networks A helper function that determines whether an IP address is loopback was checking for a "::1" substring in the IP address. Non-loopback IPv6 addresses can have that substring - e.g. "1234::1234:1234". If the test runs on a machine with one of these addresses, it would fail erroneously. The fix simply adds spaces on both sides of the pattern, so that it only matches complete IP addresses (always surrounded by spaces in an ICE candidate line). BUG=629705 ========== to ========== Fix spurious WebRTC test failure on certain IPv6 networks A helper function that determines whether an IP address is loopback was checking for a "::1" substring in the IP address. Non-loopback IPv6 addresses can have that substring - e.g. "1234::1234:1234". If the test runs on a machine with one of these addresses, it would fail erroneously. The fix simply adds spaces on both sides of the pattern, so that it only matches complete IP addresses (always surrounded by spaces in an ICE candidate line). BUG=629705 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix spurious WebRTC test failure on certain IPv6 networks A helper function that determines whether an IP address is loopback was checking for a "::1" substring in the IP address. Non-loopback IPv6 addresses can have that substring - e.g. "1234::1234:1234". If the test runs on a machine with one of these addresses, it would fail erroneously. The fix simply adds spaces on both sides of the pattern, so that it only matches complete IP addresses (always surrounded by spaces in an ICE candidate line). BUG=629705 ========== to ========== Fix spurious WebRTC test failure on certain IPv6 networks A helper function that determines whether an IP address is loopback was checking for a "::1" substring in the IP address. Non-loopback IPv6 addresses can have that substring - e.g. "1234::1234:1234". If the test runs on a machine with one of these addresses, it would fail erroneously. The fix simply adds spaces on both sides of the pattern, so that it only matches complete IP addresses (always surrounded by spaces in an ICE candidate line). BUG=629705 Committed: https://crrev.com/60b186ed1accde051b06bf74b966a88ec9b54fba Cr-Commit-Position: refs/heads/master@{#408726} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/60b186ed1accde051b06bf74b966a88ec9b54fba Cr-Commit-Position: refs/heads/master@{#408726}
Message was sent while issue was closed.
Patchset #3 (id:40001) has been deleted
Message was sent while issue was closed.
Patchset #2 (id:20001) has been deleted |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
