Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2185493002: Remove redundant includes/forward declarations in WebFrame.h (Closed)

Created:
4 years, 5 months ago by kochi
Modified:
4 years, 4 months ago
Reviewers:
dcheng
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, cbentzel+watch_chromium.org, extensions-reviews_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant includes/forward declarations in WebFrame.h NOPRESUBMIT=true Committed: https://crrev.com/4d7298c5fa3a242d6594c33759bbb33c0aace837 Cr-Commit-Position: refs/heads/master@{#407753}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -17 lines) Patch
M chrome/renderer/chrome_render_frame_observer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/net/net_error_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/image_downloader/image_downloader_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/script_context.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebDocument.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebFrame.h View 3 chunks +0 lines, -13 lines 0 comments Download
M third_party/WebKit/public/web/WebLocalFrame.h View 2 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebView.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
kochi
This is a trivial change, what I found while I was looking at WebFrame.h.
4 years, 5 months ago (2016-07-26 06:15:55 UTC) #4
dcheng
rs lgtm, thanks!
4 years, 4 months ago (2016-07-26 08:11:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185493002/1
4 years, 4 months ago (2016-07-26 08:13:36 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/225012)
4 years, 4 months ago (2016-07-26 08:19:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185493002/1
4 years, 4 months ago (2016-07-26 08:32:57 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 09:50:12 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 09:51:45 UTC) #17
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4d7298c5fa3a242d6594c33759bbb33c0aace837
Cr-Commit-Position: refs/heads/master@{#407753}

Powered by Google App Engine
This is Rietveld 408576698