Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2185483002: Revert of Disable Many AppBannerDataFetcherBrowserTest Failing Tests (Closed)

Created:
4 years, 4 months ago by dominickn
Modified:
4 years, 4 months ago
Reviewers:
Mark P
CC:
chromium-reviews, dominickn+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable Many AppBannerDataFetcherBrowserTest Failing Tests (patchset #3 id:40001 of https://codereview.chromium.org/2184503002/ ) Reason for revert: Speculative revert to see if reverting crrev.com/2183783002 fixes the failing tests in crbug.com/631190. App banners use methods touched by that CL to check if a service worker is registered. This CL will be relanded if the re-enabled tests still fail on https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29 Original issue's description: > Disable Many AppBannerDataFetcherBrowserTest Failing Tests > > TBR=dominickn@chromium.org > > BUG=631190 > > Committed: https://crrev.com/3429dff80be28f18b66b7d93718d131dc4aea9de > Cr-Commit-Position: refs/heads/master@{#407653} TBR=mpearson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=631190 Committed: https://crrev.com/178c5ea9779ea4eaab30b913548542bf2f096794 Cr-Commit-Position: refs/heads/master@{#407717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -136 lines) Patch
M chrome/browser/banners/app_banner_data_fetcher_browsertest.cc View 6 chunks +31 lines, -136 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dominickn
Created Revert of Disable Many AppBannerDataFetcherBrowserTest Failing Tests
4 years, 4 months ago (2016-07-26 05:45:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185483002/1
4 years, 4 months ago (2016-07-26 05:46:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-26 05:46:52 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-26 05:48:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/178c5ea9779ea4eaab30b913548542bf2f096794
Cr-Commit-Position: refs/heads/master@{#407717}

Powered by Google App Engine
This is Rietveld 408576698