Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 21854002: Remove experimental.record api completely (Closed)

Created:
7 years, 4 months ago by pals
Modified:
7 years, 4 months ago
Reviewers:
clintstaley, Matt Perry
CC:
chromium-reviews, extensions-reviews_chromium.org, felt, jar (doing other things), asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, Ilya Sherman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed review comments #

Patch Set 3 : Rebased the patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2146 lines) Patch
D chrome/browser/extensions/api/record/record_api.h View 1 chunk +0 lines, -168 lines 0 comments Download
D chrome/browser/extensions/api/record/record_api.cc View 1 chunk +0 lines, -261 lines 0 comments Download
D chrome/browser/extensions/api/record/record_api_test.cc View 1 chunk +0 lines, -353 lines 0 comments Download
M chrome/browser/extensions/extension_function_histogram_value.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/api/experimental_record.json View 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/common/extensions/docs/examples/api/record/page_cycler/manifest.json View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/common/extensions/docs/examples/api/record/page_cycler/page_cycler.css View 1 chunk +0 lines, -102 lines 0 comments Download
D chrome/common/extensions/docs/examples/api/record/page_cycler/page_cycler.html View 1 chunk +0 lines, -90 lines 0 comments Download
D chrome/common/extensions/docs/examples/api/record/page_cycler/page_cycler.js View 1 chunk +0 lines, -143 lines 0 comments Download
D chrome/common/extensions/docs/examples/api/record/page_cycler/page_cycler_icon.png View Binary file 0 comments Download
D chrome/common/extensions/docs/examples/api/record/page_cycler/page_cycler_icon_16.png View Binary file 0 comments Download
D chrome/common/extensions/docs/examples/apps/cycler/capture_tab.js View 1 chunk +0 lines, -92 lines 0 comments Download
D chrome/common/extensions/docs/examples/apps/cycler/cycler.css View 1 chunk +0 lines, -149 lines 0 comments Download
D chrome/common/extensions/docs/examples/apps/cycler/cycler.html View 1 chunk +0 lines, -107 lines 0 comments Download
D chrome/common/extensions/docs/examples/apps/cycler/cycler.js View 1 chunk +0 lines, -142 lines 0 comments Download
D chrome/common/extensions/docs/examples/apps/cycler/cycler_data.js View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/common/extensions/docs/examples/apps/cycler/cycler_icon.png View Binary file 0 comments Download
D chrome/common/extensions/docs/examples/apps/cycler/cycler_icon_128.png View Binary file 0 comments Download
D chrome/common/extensions/docs/examples/apps/cycler/cycler_icon_16.png View Binary file 0 comments Download
D chrome/common/extensions/docs/examples/apps/cycler/cycler_ui.js View 1 chunk +0 lines, -107 lines 0 comments Download
D chrome/common/extensions/docs/examples/apps/cycler/manifest.json View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/common/extensions/docs/examples/apps/cycler/playback_tab.js View 1 chunk +0 lines, -234 lines 0 comments Download
D chrome/common/extensions/docs/templates/public/apps/experimental_record.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/templates/public/extensions/experimental_record.html View 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
pals
PTAL, thanks
7 years, 4 months ago (2013-08-02 13:42:15 UTC) #1
felt
https://codereview.chromium.org/21854002/diff/1/chrome/browser/extensions/activity_log/api_name_constants.h File chrome/browser/extensions/activity_log/api_name_constants.h (left): https://codereview.chromium.org/21854002/diff/1/chrome/browser/extensions/activity_log/api_name_constants.h#oldcode80 chrome/browser/extensions/activity_log/api_name_constants.h:80: "experimental.record.captureURLs", "experimental.record.replayURLs", As the comment at the top of ...
7 years, 4 months ago (2013-08-02 13:52:26 UTC) #2
Matt Perry
https://codereview.chromium.org/21854002/diff/1/chrome/browser/ui/browser_window_state.cc File chrome/browser/ui/browser_window_state.cc (left): https://codereview.chromium.org/21854002/diff/1/chrome/browser/ui/browser_window_state.cc#oldcode94 chrome/browser/ui/browser_window_state.cc:94: bool record_mode = parsed_command_line.HasSwitch(switches::kRecordMode); This is used outside the ...
7 years, 4 months ago (2013-08-02 21:19:08 UTC) #3
pals
Fixed review comments. PTAL
7 years, 4 months ago (2013-08-05 05:11:31 UTC) #4
pals
Fixed review comments. PTAL https://codereview.chromium.org/21854002/diff/1/chrome/browser/extensions/activity_log/api_name_constants.h File chrome/browser/extensions/activity_log/api_name_constants.h (left): https://codereview.chromium.org/21854002/diff/1/chrome/browser/extensions/activity_log/api_name_constants.h#oldcode80 chrome/browser/extensions/activity_log/api_name_constants.h:80: "experimental.record.captureURLs", "experimental.record.replayURLs", On 2013/08/02 13:52:26, ...
7 years, 4 months ago (2013-08-05 05:35:55 UTC) #5
Matt Perry
lgtm
7 years, 4 months ago (2013-08-05 22:03:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/21854002/6001
7 years, 4 months ago (2013-08-06 01:49:07 UTC) #7
commit-bot: I haz the power
Failed to apply patch for chrome/chrome_browser_extensions.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 4 months ago (2013-08-06 01:49:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/21854002/13001
7 years, 4 months ago (2013-08-06 05:08:32 UTC) #9
commit-bot: I haz the power
7 years, 4 months ago (2013-08-06 07:35:26 UTC) #10
Message was sent while issue was closed. 
Change committed as 215835

Powered by Google App Engine
This is Rietveld 408576698