Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2185333002: Exclude nested submodules properly. This never worked. (Closed)

Created:
4 years, 4 months ago by dsansome
Modified:
4 years, 4 months ago
Reviewers:
agable
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Exclude nested submodules properly. This never worked. BUG= TBR=agable Committed: https://chromium.googlesource.com/chromium/tools/build/+/394d6f00e87c96da80bcf69cdf451a2af0bf349d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M scripts/slave/recipe_modules/sync_submodules/resources/deps2submodules.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
dsansome
4 years, 4 months ago (2016-07-28 04:42:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185333002/1
4 years, 4 months ago (2016-07-28 04:42:17 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 04:45:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/394d6f00e87c96da80bc...

Powered by Google App Engine
This is Rietveld 408576698