Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2185303002: Revert changes to device/test/run_all_unittests.cc (Closed)

Created:
4 years, 4 months ago by tsergeant
Modified:
4 years, 4 months ago
Reviewers:
mcasas, Paul Stewart
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert changes to device/test/run_all_unittests.cc Changes to this file were made in https://codereview.chromium.org/2185993003/. However, they were not reverted when the remainder of that patch was reverted in https://codereview.chromium.org/2188933002/. This should fix the Android build. TBR=pstew@chromium.org,mcasas@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=612334 Committed: https://crrev.com/77d0c290852d4d0042ec117ca28592b77c084729 Cr-Commit-Position: refs/heads/master@{#408310}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M device/test/run_all_unittests.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tsergeant
4 years, 4 months ago (2016-07-28 01:55:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185303002/1
4 years, 4 months ago (2016-07-28 01:56:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 01:56:57 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/77d0c290852d4d0042ec117ca28592b77c084729 Cr-Commit-Position: refs/heads/master@{#408310}
4 years, 4 months ago (2016-07-28 01:58:50 UTC) #6
mcasas
On 2016/07/28 01:58:50, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 4 months ago (2016-07-28 02:44:03 UTC) #7
tsergeant
4 years, 4 months ago (2016-07-28 02:50:08 UTC) #8
Message was sent while issue was closed.
On 2016/07/28 02:44:03, mcasas wrote:
> On 2016/07/28 01:58:50, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/77d0c290852d4d0042ec117ca28592b77c084729
> > Cr-Commit-Position: refs/heads/master@{#408310}
> 
> LGTM, thanks!
> 
> the revert did not revert the original CL 100% ?!?!?
> =-0

Yeah, somehow this file got left out. I've got no idea how.

Powered by Google App Engine
This is Rietveld 408576698