Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2185293004: [interpreter] Reduce size of OSR nesting level field. (Closed)

Created:
4 years, 4 months ago by Michael Starzinger
Modified:
4 years, 4 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Reduce size of OSR nesting level field. R=rmcilroy@chromium.org BUG=v8:4764 Committed: https://crrev.com/4f0029a481ed96a3dd5dfb78d04e8f40ce2c0bc1 Cr-Commit-Position: refs/heads/master@{#38147}

Patch Set 1 #

Patch Set 2 : Add static assert. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M src/interpreter/interpreter-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Michael Starzinger
4 years, 4 months ago (2016-07-28 15:31:01 UTC) #3
rmcilroy
LGTM, thanks.
4 years, 4 months ago (2016-07-28 16:20:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185293004/20001
4 years, 4 months ago (2016-07-28 17:16:25 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-28 17:18:03 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 17:20:06 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4f0029a481ed96a3dd5dfb78d04e8f40ce2c0bc1
Cr-Commit-Position: refs/heads/master@{#38147}

Powered by Google App Engine
This is Rietveld 408576698