Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2185293002: [Media Router] Rename mojo namespace from interfaces to mojom (Closed)

Created:
4 years, 4 months ago by btolsch
Modified:
4 years, 4 months ago
Reviewers:
imcheng, dcheng
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, media-router+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, mcasas+watch+vc_chromium.org, darin (slow to review), ben+mojo_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Rename mojo namespace from interfaces to mojom BUG=629376 Committed: https://crrev.com/55453b87da7d3b1e82c918547d13320015562b9d Cr-Commit-Position: refs/heads/master@{#408363}

Patch Set 1 #

Patch Set 2 : Rename mojo namespace in tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -204 lines) Patch
M chrome/browser/media/router/mojo/media_router.mojom View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_impl.h View 7 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_impl.cc View 18 chunks +25 lines, -25 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc View 1 39 chunks +83 lines, -83 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_test.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router_mojo_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router_type_converters.h View 1 chunk +15 lines, -15 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router_type_converters.cc View 4 chunks +26 lines, -26 lines 0 comments Download
M chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc View 8 chunks +27 lines, -27 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
btolsch
PTAL, thanks!
4 years, 4 months ago (2016-07-28 01:55:49 UTC) #2
dcheng
rs lgtm
4 years, 4 months ago (2016-07-28 02:10:15 UTC) #3
imcheng
lgtm
4 years, 4 months ago (2016-07-28 02:15:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185293002/1
4 years, 4 months ago (2016-07-28 02:21:19 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/200300) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 4 months ago (2016-07-28 02:29:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185293002/20001
4 years, 4 months ago (2016-07-28 08:56:35 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-28 08:59:50 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 09:01:36 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55453b87da7d3b1e82c918547d13320015562b9d
Cr-Commit-Position: refs/heads/master@{#408363}

Powered by Google App Engine
This is Rietveld 408576698