Fix not throwing error when redefine eval or arguments in strict mode.

test/cctest/test-parsing.cc

Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index 090a9d00e7318f05e80393dc37a72c046089a8aa..3f93db2932ecefeba0efa7b006e37bfe03bb3f30 100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -6550,6 +6550,22 @@ TEST(DestructuringAssignmentPositiveTests) {
       NULL,
   };
   RunParserSyncTest(empty_context_data, ambiguity_data, kSuccess);
+
+  // v8:5201
+  {
+    const char* context_data[][2] = {
+      {"var {", "} = {};"},
+      {"(() => { function f({", " = false } = {}) {} })()"},
+      {NULL, NULL}
+    };
+
+    const char* data[] = {
+      "eval",

[adamk, 2016/08/09 17:00:51]

I think this test case belongs with the other destructuring bind tests in
DestructuringPositiveTests

You'll want to add a section there for strict/sloppy, just like there is in this
one. But there's no need for a whole separate call for RunParserSyncTest.

Once you're there, you'll want to add a bunch more test cases. In particular, I
think this actually will fail, though it shouldn't:


{eval: x}

which means "bind the property named 'eval' to the variable 'x'". So more work
is needed in the code too.

+      NULL,
+    };
+
+    RunParserSyncTest(context_data, data, kSuccess);
+  }
 }
 
 
@@ -6715,6 +6731,25 @@ TEST(DestructuringAssignmentNegativeTests) {
 
                                NULL};
   RunParserSyncTest(strict_context_data, strict_data, kError);
+
+  // v8:5201
+  {
+    // clang-format off
+    const char* context_data[][2] = {
+      {"'use strict'; var {", "} = {};"},
+      {"(() => { 'use strict'; function a({", " = false } = {}) {} })()"},
+      {NULL, NULL}
+    };
+
+    const char* data[] = {
+      "eval",
+      "arguments",
+      NULL
+    };
+
+    // clang-format on
+    RunParserSyncTest(context_data, data, kError);
+  }
 }