Fix not throwing error when redefine eval or arguments in strict mode.

test/cctest/test-parsing.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 6327 matching lines @@
     "{[x] : z}",
     "{[1+1] : z}",
     "{[foo()] : z}",
     "{}",
     "[...rest]",
     "[a,b,...rest]",
     "[a,,...rest]",
     NULL};
   // clang-format on
   RunParserSyncTest(context_data, data, kSuccess);
+
+  // v8:5201
+  {
+    const char* context_data[][2] = {
+      {"", ""},
+      {NULL, NULL}
+    };
+
+    const char* data[] = {
+      "var {eval} = {}",
+      "var {arguments} = {}",
+      "'use strict'; var {eval: x} = {eval: 5};",
+      "'use strict'; var {arguments: x} = {arguments: 5};",
+      "(() => { function f({eval = false } = {}) {} })()",
+      NULL,
+    };
+
+    RunParserSyncTest(context_data, data, kSuccess);
+  }
 }
 
 
 TEST(DestructuringNegativeTests) {
   {  // All modes.
     const char* context_data[][2] = {{"'use strict'; let ", " = {};"},
                                      {"var ", " = {};"},
                                      {"'use strict'; const ", " = {};"},
                                      {"function f(", ") {}"},
                                      {"function f(argument1, ", ") {}"},
@@ skipping 104 matching lines @@
         {"'use strict'; function f(", ") {}"},
         {"'use strict'; function f(argument1, ", ") {}"},
         {NULL, NULL}};
 
     // clang-format off
     const char* data[] = {
       "[eval]",
       "{ a : arguments }",
       "[public]",
       "{ x : private }",
+      "{eval}",
+      "{arguments}",

[adamk, 2016/08/17 19:32:51]

Can you flesh out this test coverage while you're here? e.g., we test for
"[eval]" but not "[arguments]". Similarly I'd like to see "{e : eval}", and
similarly versions with defaults ("{eval = 0 }"). This test clearly thought it
was covering these things previously and they were missed.

[lpy, 2016/08/19 17:00:40]

Done.

       NULL};
     // clang-format on
     RunParserSyncTest(context_data, data, kError);
   }
 
   {  // 'yield' in generators.
     const char* context_data[][2] = {
         {"function*() { var ", " = {};"},
         {"function*() { 'use strict'; let ", " = {};"},
         {"function*() { 'use strict'; const ", " = {};"},
@@ skipping 383 matching lines @@
                                "[ (arguments) = 0 ]",
                                "[ ...(eval) ]",
                                "[ ...(arguments) ]",
                                "[ ...(eval = 0) ]",
                                "[ ...(arguments = 0) ]",
                                "[ ...(eval) = 0 ]",
                                "[ ...(arguments) = 0 ]",
 
                                NULL};
   RunParserSyncTest(strict_context_data, strict_data, kError);
+
+  // v8:5201

[adamk, 2016/08/17 19:32:51]

Isn't this block now redundant with the tests you added on line 6491?

[lpy, 2016/08/19 17:00:40]

Done.

+  {
+    // clang-format off
+    const char* context_data[][2] = {
+      {"'use strict'; var {", "} = {};"},
+      {"(() => { 'use strict'; function a({", " = false } = {}) {} })()"},
+      {NULL, NULL}
+    };
+
+    const char* data[] = {
+      "eval",
+      "arguments",
+      NULL
+    };
+
+    // clang-format on
+    RunParserSyncTest(context_data, data, kError);
+  }
 }
 
 
 TEST(DestructuringDisallowPatternsInForVarIn) {
   const char* context_data[][2] = {
       {"", ""}, {"function f() {", "}"}, {NULL, NULL}};
   // clang-format off
   const char* error_data[] = {
     "for (let x = {} in null);",
     "for (let x = {} of null);",
@@ skipping 1256 matching lines @@
     "(a,);",
     "(a,b,c,);",
     NULL
   };
   // clang-format on
 
   static const ParserFlag always_flags[] = {kAllowHarmonyTrailingCommas};
   RunParserSyncTest(context_data, data, kError, NULL, 0, always_flags,
                     arraysize(always_flags));
 }