Fix not throwing error when redefine eval or arguments in strict mode.

src/parsing/parser-base.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_PARSING_PARSER_BASE_H
 #define V8_PARSING_PARSER_BASE_H
 
 #include "src/ast/scopes.h"
 #include "src/bailout-reason.h"
 #include "src/base/hashmap.h"
@@ skipping 1889 matching lines @@
       Traits::RewriteNonPattern(&computed_name_classifier, CHECK_OK);
       classifier->Accumulate(&computed_name_classifier,
                              ExpressionClassifier::ExpressionProductions);
       Expect(Token::RBRACK, CHECK_OK);
       return expression;
     }
 
     default:
       *name = ParseIdentifierName(CHECK_OK);
       scanner()->IsGetOrSet(is_get, is_set);
       if (this->IsAwait(*name)) {

[adamk, 2016/08/05 22:29:29]

I actually don't know why we handle this here instead of in the caller...see
below.

[lpy, 2016/08/09 01:01:47]

Done.

         *is_await = true;
+      } else if (this->IsEval(*name)) {

[adamk, 2016/08/05 22:29:29]

What about "arguments"?

Is there a reason check has to be done here, and not in the caller? It seems
like we handle most of the other similar errors in ParsePropertyDefinition, in
the block that handles the PropertyDefinition production.

[lpy, 2016/08/09 01:01:47]

My understanding is when parsing the property name, when a specific word
encountered, it will record (for example, set is_await).

But since `name` is an out parameter, I think we can do it in caller.

Not sure if we should do this in a separate CL for await, I move the error
report for eval and arguments to caller as suggested.

+        classifier->RecordStrictModeFormalParameterError(

[adamk, 2016/08/05 22:29:29]

Not clear on why this is an error in sloppy mode.

Can you add the test-parsing.cc tests we discussed? That'd let us more easily
verify that we get the right behavior in strict vs sloppy.

+            scanner()->location(), MessageTemplate::kStrictEvalArguments);
+        if (is_strict(language_mode())) {
+          classifier->RecordBindingPatternError(
+              scanner()->location(), MessageTemplate::kStrictEvalArguments);
+        }
       }
       break;
   }
 
   uint32_t index;
   return this->IsArrayIndex(*name, &index)
              ? factory()->NewNumberLiteral(index, pos)
              : factory()->NewStringLiteral(*name, pos);
 }
 
@@ skipping 1771 matching lines @@
     has_seen_constructor_ = true;
     return;
   }
 }
 
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_PARSING_PARSER_BASE_H