Fix not throwing error when redefine eval or arguments in strict mode.

test/mjsunit/strict-mode-eval.js

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 13 matching lines @@
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 "use strict";
 
 var code1 = "function f(eval) {}";
 var code2 = "function f(a, a) {}";
 var code3 = "var x = '\\020;'";
 var code4 = "function arguments() {}";
+var code5 = "(() => { function a({ eval = false } = {}) {} })()";

[adamk, 2016/07/28 18:33:44]

Is the outer arrow function an important part of this test case?

 
 // Verify the code compiles just fine in non-strict mode
 // (using aliased eval to force non-strict mode)
 var eval_alias = eval;
 
 eval_alias(code1);
 eval_alias(code2);
 eval_alias(code3);
 eval_alias(code4);

[adamk, 2016/07/28 18:33:44]

Can you add code5 here too?

[lpy, 2016/08/05 22:15:42]

Done.

 
 function strict1() {
   var exception = false;
   try {
     eval(code1);
   } catch (e) {
     exception = true;
     assertInstanceof(e, SyntaxError);
   }
   assertTrue(exception);
@@ skipping 20 matching lines @@
 
       function strict4() {
         var exception = false;
         try {
           eval(code4);
         } catch (e) {
           exception = true;
           assertInstanceof(e, SyntaxError);
         }
         assertTrue(exception);
+
+        function strict5() {
+          var exception = false;
+          try {
+            eval(code5);
+          } catch (e) {
+            exception = true;
+            assertInstanceof(e, SyntaxError);
+          }
+          assertTrue(exception);
+        }
+        strict5();
       }
       strict4();
     }
     strict3();
   }
   strict2();
 }
 strict1();