Fix not throwing error when redefine eval or arguments in strict mode.

test/cctest/test-parsing.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 6327 matching lines @@
     "{[x] : z}",
     "{[1+1] : z}",
     "{[foo()] : z}",
     "{}",
     "[...rest]",
     "[a,b,...rest]",
     "[a,,...rest]",
     NULL};
   // clang-format on
   RunParserSyncTest(context_data, data, kSuccess);
+
+  // v8:5201
+  {
+    const char* sloppy_context_data[][2] = {
+      {"", ""},
+      {NULL, NULL}
+    };
+    const char* data1[] = {
+      "var {arguments} = {}",
+      "var {eval} = {}",
+      "var {x: arguments} = {x: 5}",
+      "var {x: eval} = {x: 5}",
+      "function f({eval = false } = {}) {}",
+      "function f(argument1, {eval = false} = {}) {}",
+      "function f(argument1, {eval} = {}) {}",

[adamk, 2016/08/19 18:14:56]

Rather than enumerating different surrounding stuff here, I'd prefer if the
context_data contained the outer bits and the tests themselves were just
patterns, like the rest of the destructuring tests.

For context, var declarations and functions are a good start, but I think you
also want an arrow function example (I'd just copy the context_data for the
positive tests and remove the "strict" ones).

[lpy, 2016/08/19 18:58:17]

Done.

+      NULL,
+    };
+    RunParserSyncTest(sloppy_context_data, data1, kSuccess);
+
+    const char* empty_context_data[][2] = {
+      {"'use strict';", ""},
+      {"", ""},
+      {NULL, NULL}
+    };
+    const char* data2[] = {
+      "var {arguments: x} = {argumnets: 1};",
+      "var {eval: x} = {eval: 1};",

[adamk, 2016/08/19 18:14:56]

These two tests can just go in the main block of test cases ("data"), as
"{arguments: x}" and "{eval: x}"

[lpy, 2016/08/19 18:58:17]

Done.

+      NULL
+    };
+    RunParserSyncTest(empty_context_data, data2, kSuccess);
+  }
 }
 
 
 TEST(DestructuringNegativeTests) {
   {  // All modes.
     const char* context_data[][2] = {{"'use strict'; let ", " = {};"},
                                      {"var ", " = {};"},
                                      {"'use strict'; const ", " = {};"},
                                      {"function f(", ") {}"},
                                      {"function f(argument1, ", ") {}"},
@@ skipping 92 matching lines @@
     const char* data[] = {
         "x => x",
         "() => x",
         NULL};
     // clang-format on
     RunParserSyncTest(context_data, data, kError);
   }
 
   {  // Strict mode.
     const char* context_data[][2] = {
+        {"'use strict'; var ", " = {};"},
         {"'use strict'; let ", " = {};"},
         {"'use strict'; const ", " = {};"},
         {"'use strict'; function f(", ") {}"},
         {"'use strict'; function f(argument1, ", ") {}"},
         {NULL, NULL}};
 
     // clang-format off
     const char* data[] = {
+      "[arguments]",
       "[eval]",
       "{ a : arguments }",
+      "{ a : eval }",
       "[public]",
       "{ x : private }",
+      "{ x : arguments }",
+      "{ x : eval }",
+      "{ arguments }",
+      "{ eval }",
+      "{ arguments = false }"
+      "{ eval = false }",
       NULL};
     // clang-format on
     RunParserSyncTest(context_data, data, kError);
   }
 
   {  // 'yield' in generators.
     const char* context_data[][2] = {
         {"function*() { var ", " = {};"},
         {"function*() { 'use strict'; let ", " = {};"},
         {"function*() { 'use strict'; const ", " = {};"},
@@ skipping 1659 matching lines @@
     "(a,);",
     "(a,b,c,);",
     NULL
   };
   // clang-format on
 
   static const ParserFlag always_flags[] = {kAllowHarmonyTrailingCommas};
   RunParserSyncTest(context_data, data, kError, NULL, 0, always_flags,
                     arraysize(always_flags));
 }