Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1492)

Unified Diff: chrome/browser/ui/website_settings/website_settings.cc

Issue 2185213002: Display USB devices in the site settings popup on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/website_settings.cc
diff --git a/chrome/browser/ui/website_settings/website_settings.cc b/chrome/browser/ui/website_settings/website_settings.cc
index ad39bb6d1194537cca56ba2c07ff5397d1291a2a..955bd607011d5dba1ccbe141a42a7b5ae16de78b 100644
--- a/chrome/browser/ui/website_settings/website_settings.cc
+++ b/chrome/browser/ui/website_settings/website_settings.cc
@@ -201,8 +201,8 @@ ChooserContextBase* GetUsbChooserContext(Profile* profile) {
// Settings UI. THE ORDER OF THESE ITEMS IS IMPORTANT. To propose changing it,
// email security-dev@chromium.org.
WebsiteSettings::ChooserUIInfo kChooserUIInfo[] = {
- {&GetUsbChooserContext, IDR_BLOCKED_USB, IDR_ALLOWED_USB,
- IDS_WEBSITE_SETTINGS_USB_DEVICE_LABEL,
+ {CONTENT_SETTINGS_TYPE_USB_CHOOSER_DATA, &GetUsbChooserContext,
benwells 2016/07/28 07:51:13 Is there a plan to remove this USB specific code f
Reilly Grant (use Gerrit) 2016/07/28 17:55:43 Can you explain why it is wrong to have this here?
benwells 2016/07/29 05:01:39 OK, my bad, I got a bit mixed up.
+ IDR_BLOCKED_USB, IDR_ALLOWED_USB, IDS_WEBSITE_SETTINGS_USB_DEVICE_LABEL,
IDS_WEBSITE_SETTINGS_DELETE_USB_DEVICE, "name"},
};

Powered by Google App Engine
This is Rietveld 408576698