Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2185203003: Add swarmbucket_wrapper recipe (Closed)

Created:
4 years, 4 months ago by borenet2
Modified:
4 years, 4 months ago
Reviewers:
borenet, rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -0 lines) Patch
A infra/bots/recipes/swarmbucket_wrapper.py View 1 1 chunk +121 lines, -0 lines 0 comments Download
A infra/bots/recipes/swarmbucket_wrapper.expected/trigger_recipe.json View 1 chunk +118 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
borenet
4 years, 4 months ago (2016-07-28 17:19:23 UTC) #3
rmistry
https://codereview.chromium.org/2185203003/diff/1/infra/bots/recipes/swarmbucket_wrapper.py File infra/bots/recipes/swarmbucket_wrapper.py (right): https://codereview.chromium.org/2185203003/diff/1/infra/bots/recipes/swarmbucket_wrapper.py#newcode21 infra/bots/recipes/swarmbucket_wrapper.py:21: def checkout_steps(api): Can we add a bunch of documentation ...
4 years, 4 months ago (2016-07-28 17:41:48 UTC) #4
borenet
https://codereview.chromium.org/2185203003/diff/1/infra/bots/recipes/swarmbucket_wrapper.py File infra/bots/recipes/swarmbucket_wrapper.py (right): https://codereview.chromium.org/2185203003/diff/1/infra/bots/recipes/swarmbucket_wrapper.py#newcode21 infra/bots/recipes/swarmbucket_wrapper.py:21: def checkout_steps(api): On 2016/07/28 17:41:48, rmistry wrote: > Can ...
4 years, 4 months ago (2016-07-28 17:46:01 UTC) #5
rmistry
lgtm
4 years, 4 months ago (2016-07-28 17:47:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2185203003/20001
4 years, 4 months ago (2016-07-28 17:50:04 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 17:50:57 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f49d9d77bbaf9b075426046173c976a15bde8ee5

Powered by Google App Engine
This is Rietveld 408576698