src/IceTargetLoweringX86BaseImpl.h - Issue 2185193002: Enable Local CSE by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringX86BaseImpl.h

Issue 2185193002: Enable Local CSE by default (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Address Comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceTargetLoweringX86BaseImpl.h

diff --git a/src/IceTargetLoweringX86BaseImpl.h b/src/IceTargetLoweringX86BaseImpl.h

index 2acd3312d9b9b74c6a30853cc7cabcab2d2ff59d..eee8f5d3eb79faf66275a9a539525b0255c15d21 100644

--- a/src/IceTargetLoweringX86BaseImpl.h

+++ b/src/IceTargetLoweringX86BaseImpl.h

@@ -455,8 +455,8 @@ template <typename TraitsType> void TargetX86Base<TraitsType>::translateO2() {

Func->dump("After LICM");

}

- if (getFlags().getEnableExperimental()) {

- Func->localCSE();

+ if (getFlags().getLocalCSE() != Ice::LCSE_Disabled) {

+ Func->localCSE(getFlags().getLocalCSE() == Ice::LCSE_EnabledSSA);

Func->dump("After Local CSE");

}

if (getFlags().getEnableShortCircuit()) {